Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebay-table: various fixes #2313

Closed
agliga opened this issue Nov 1, 2024 · 1 comment · Fixed by #2387
Closed

ebay-table: various fixes #2313

agliga opened this issue Nov 1, 2024 · 1 comment · Fixed by #2387
Assignees
@WinkeeFace
Labels
component: table semvar: breaking changes status: merged
Milestone
15.0.0

Comments

@agliga
Copy link
Contributor

agliga commented Nov 1, 2024 •
edited
Loading

  • column-type: row-header does not sit well in here. Should move out, make it a boolean
@agliga agliga added this to eBayUI Nov 1, 2024
@agliga agliga added this to the 15.0.0 milestone Dec 19, 2024
@agliga agliga moved this to Todo in eBayUI Dec 19, 2024
@agliga agliga mentioned this issue Dec 19, 2024
Closed
1 task
@agliga agliga assigned agliga and WinkeeFace and unassigned agliga Dec 19, 2024
@WinkeeFace WinkeeFace linked a pull request Dec 24, 2024 that will close this issue
fix(table): replaced column-type of "row-header" with boolean row-header #2355
Closed
@WinkeeFace WinkeeFace mentioned this issue Dec 24, 2024
Closed
@WinkeeFace WinkeeFace moved this from Todo to In Progress in eBayUI Dec 30, 2024
@WinkeeFace
Copy link
Contributor

Blocked: eBayUI is using an outdated version of @marko/type-check, and the latest version needed to fix the type narrowing issue is incompatible. Awaiting resolution from the Marko team to upgrade and ensure compatibility.

@WinkeeFace WinkeeFace mentioned this issue Jan 17, 2025
Merged
1 task
@WinkeeFace WinkeeFace linked a pull request Jan 17, 2025 that will close this issue
fix(ebay-table): update row-header attribute, removed aria-pressed #2387
Merged
1 task
@agliga agliga moved this from In Progress to Pull request in eBayUI Jan 21, 2025
@agliga agliga moved this from Pull request to Done in eBayUI Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WinkeeFace WinkeeFace

Labels
component: table semvar: breaking changes status: merged
Projects
eBayUI
Status: Done
Milestone
15.0.0
2 participants
@agliga @WinkeeFace