Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item tile: EEK icon size #2447

Open
3 tasks done
fwg001 opened this issue Sep 16, 2024 · 5 comments
Open
3 tasks done

Item tile: EEK icon size #2447

fwg001 opened this issue Sep 16, 2024 · 5 comments

Comments

@fwg001
Copy link

fwg001 commented Sep 16, 2024

Description

Item Tile component displays the Eek icon at a different size from the DS spec.
The design system spec shows 24px height for Eek Icon whereas Skin sets its height to 28px.
Please update skin to 24px.

Screenshots

Design spec

Figma link

https://www.figma.com/design/zEBdEhbonrBOGzZ0fXzWvM/eBay-Design-System?node-id=127302-223990&m=dev

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@agliga
Copy link
Contributor

agliga commented Sep 16, 2024

We need the svg asset for the outline arrow in order to fix this.

@agliga
Copy link
Contributor

agliga commented Sep 16, 2024

This is the asset we have from design. Its 28px viewbox height.

https://github.com/eBay/skin/blob/master/src/svg/icon/icon-eek-arrow.svg

@agliga
Copy link
Contributor

agliga commented Sep 16, 2024

This also could be a possible breaking change since we are changing the height and need the icon to be swapped out.

@ratinsl
Copy link

ratinsl commented Sep 21, 2024

@agliga try this 24px asset out. The original asset looked pretty chopped up on the corners. I adjusted everything to not be chopped off. Let me know how it looks or if I need to make any more adjustments.

icon-eek-arrow.svg.zip

Screenshot 2024-09-20 at 10 39 23 PM

@agliga agliga added this to the 18.4.0 milestone Sep 27, 2024
@agliga agliga added the size: 1 label Sep 27, 2024
@agliga
Copy link
Contributor

agliga commented Sep 27, 2024

Will be breaking. Will need to add a variant to show smaller size.

@agliga agliga self-assigned this Sep 27, 2024
@agliga agliga mentioned this issue Oct 8, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants