Skip to content

Commit bf183e0

Browse files
committed
remove nbf for now
1 parent 091c188 commit bf183e0

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

src/modules/internet/index.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,6 @@ export class InternetModule extends ModuleBase {
817817
* @param options.payload.iss Issuer claim.
818818
* @param options.payload.sub Subject claim.
819819
* @param options.payload.aud Audience claim.
820-
* @param options.payload.nbf Not before claim.
821820
* @param options.payload.jti JWT ID claim.
822821
* @param options.refDate The date to use as reference point for the newly generated date.
823822
*
@@ -830,8 +829,6 @@ export class InternetModule extends ModuleBase {
830829
* faker.internet.jwt({ payload: { iss: 'Acme', sub: 'Subject' }})
831830
* faker.internet.jwt({ payload: { iss: 'Acme', sub: 'Subject', aud: 'Audience' }})
832831
* faker.internet.jwt({ payload: { iss: 'Acme', sub: 'Subject', aud: 'Audience', jti: 'JWT ID' }})
833-
* faker.internet.jwt({ payload: { iss: 'Acme', sub: 'Subject', aud: 'Audience', jti: 'JWT ID', nbf: new Date() }})
834-
* faker.internet.jwt({ payload: { iss: 'Acme', sub: 'Subject', aud: 'Audience', jti: 'JWT ID', nbf: 1717132091 }})
835832
*
836833
* @since 8.0.0
837834
*/
@@ -866,11 +863,6 @@ export class InternetModule extends ModuleBase {
866863
* @default faker.string.uuid()
867864
*/
868865
aud?: string;
869-
870-
/**
871-
* Not before claim
872-
*/
873-
nbf?: Date | string;
874866
/**
875867
* JWT ID claim
876868
*
@@ -899,14 +891,12 @@ export class InternetModule extends ModuleBase {
899891

900892
const iat = this.faker.date.recent({ refDate });
901893
const exp = this.faker.date.soon({ refDate: iat });
902-
const nbf = options?.payload?.nbf ?? this.faker.date.anytime({ refDate });
894+
const nbf = this.faker.date.anytime({ refDate });
903895

904896
const payload = {
905897
iat: Math.round(iat.valueOf() / 1000),
906898
exp: Math.round(exp.valueOf() / 1000),
907-
nbf: nbf instanceof Date
908-
? Math.round(nbf.valueOf() / 1000)
909-
: Math.round(new Date(nbf).valueOf() / 1000),
899+
nbf: Math.round(nbf.valueOf() / 1000),
910900
iss: options?.payload?.iss ?? this.faker.company.name(),
911901
sub: options?.payload?.sub ?? this.faker.string.uuid(),
912902
aud: options?.payload?.aud ?? this.faker.string.uuid(),

test/modules/__snapshots__/internet.spec.ts.snap

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ exports[`internet > 42 > jwt > with payload.iss 1`] = `"eyJhbGciOiJSUzM4NCIsInR5
8080

8181
exports[`internet > 42 > jwt > with payload.jti 1`] = `"eyJhbGciOiJSUzM4NCIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3Njc5NzgsImV4cCI6MTU3Nzg1MDEyMCwibmJmIjoxNTU3ODcwMzk5LCJpc3MiOiJTYXR0ZXJmaWVsZCwgTWlsbGVyIGFuZCBNZXR6Iiwic3ViIjoiMjcyMTA3ZDUtOTJiYS00MDBmLTliZGYtMzAyZjI5NDk4MDYwIiwiYXVkIjoiODk2MjA0ZjUtMzcxYy00OTM2LWE4ZjktNzBkOWEyNzEwZmZmIiwianRpIjoiand0IGlkIn0.Oni06eGerG7BuP2aUogbFKjqwcxzb1YQMrWoTVBJVk5zcw2XkQoKgxPAmXhBxh8i"`;
8282

83-
exports[`internet > 42 > jwt > with payload.nbf 1`] = `"eyJhbGciOiJSUzM4NCIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3Njc5NzgsImV4cCI6MTU3Nzg1MDEyMCwibmJmIjoxNzE3NDk1NjEzLCJpc3MiOiJSZXlub2xkcyBHcm91cCIsInN1YiI6Ijk5MjcyMTA3LWQ1OTItNGJhMC05MGZiLWRmMzAyZjI5NDk4MCIsImF1ZCI6IjA0ODk2MjA0LWY1MzctNDFjOS1iMzY4LWY5NzBkOWEyNzEwZiIsImp0aSI6ImY5YzY0MDEzLWEzN2EtNDE5Ny04ZDAyLWU2NDJhYzQ2ODM4OSJ9.1YQMrWoTVBJVk5zcw2XkQoKgxPAmXhBxh8iNa40ZqLoci00OcHIJMLB4VmE7URQC"`;
84-
8583
exports[`internet > 42 > jwt > with payload.sub 1`] = `"eyJhbGciOiJSUzM4NCIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3Njc5NzgsImV4cCI6MTU3Nzg1MDEyMCwibmJmIjoxNTU3ODcwMzk5LCJpc3MiOiJTYXR0ZXJmaWVsZCwgTWlsbGVyIGFuZCBNZXR6Iiwic3ViIjoic3ViamVjdCIsImF1ZCI6IjI3MjEwN2Q1LTkyYmEtNDAwZi05YmRmLTMwMmYyOTQ5ODA2MCIsImp0aSI6Ijg5NjIwNGY1LTM3MWMtNDkzNi1hOGY5LTcwZDlhMjcxMGZmZiJ9.Oni06eGerG7BuP2aUogbFKjqwcxzb1YQMrWoTVBJVk5zcw2XkQoKgxPAmXhBxh8i"`;
8684

8785
exports[`internet > 42 > mac > noArgs 1`] = `"5f:b9:22:0d:9b:0f"`;
@@ -210,8 +208,6 @@ exports[`internet > 1211 > jwt > with payload.iss 1`] = `"eyJhbGciOiJQUzUxMiIsIn
210208

211209
exports[`internet > 1211 > jwt > with payload.jti 1`] = `"eyJhbGciOiJQUzUxMiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3OTcxNDEsImV4cCI6MTU3Nzg3NDMzNywibmJmIjoxNTk1Mzg3ODE4LCJpc3MiOiJDaHJpc3RpYW5zZW4gR3JvdXAiLCJzdWIiOiIwYTJhM2M2NS0yYmJkLTQwY2EtOGFiZC1lNjRkZmRmMzc5ZTMiLCJhdWQiOiI1OWY3YzA2NC1lMDg2LTRmMjMtOTk0Mi1iNjhlNWZkNDY5NDYiLCJqdGkiOiJqd3QgaWQifQ.za4yeHe82HQuDfcpqcAQpzzt42EHybCHuh9MFvHstd9BxSr6wQss3nAtIz5OSxxV"`;
212210

213-
exports[`internet > 1211 > jwt > with payload.nbf 1`] = `"eyJhbGciOiJQUzUxMiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3OTcxNDEsImV4cCI6MTU3Nzg3NDMzNywibmJmIjoxNzE3NDk1NjEzLCJpc3MiOiJGYWhleSwgQ2hyaXN0aWFuc2VuIGFuZCBaaWVtZSIsInN1YiI6IjBhMmEzYzY1LTJiYmQtNDBjYS04YWJkLWU2NGRmZGYzNzllMyIsImF1ZCI6IjU5ZjdjMDY0LWUwODYtNGYyMy05OTQyLWI2OGU1ZmQ0Njk0NiIsImp0aSI6IjkyMTgzYjMyLTBiZDctNGEzMy1hNjYzLTlkNjk5NzEwYWI4MiJ9.Huh9MFvHstd9BxSr6wQss3nAtIz5OSxxVXYJO5S7dHIFPulAT01KxnLZtg4RgA8y"`;
214-
215211
exports[`internet > 1211 > jwt > with payload.sub 1`] = `"eyJhbGciOiJQUzUxMiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3OTcxNDEsImV4cCI6MTU3Nzg3NDMzNywibmJmIjoxNTk1Mzg3ODE4LCJpc3MiOiJDaHJpc3RpYW5zZW4gR3JvdXAiLCJzdWIiOiJzdWJqZWN0IiwiYXVkIjoiMGEyYTNjNjUtMmJiZC00MGNhLThhYmQtZTY0ZGZkZjM3OWUzIiwianRpIjoiNTlmN2MwNjQtZTA4Ni00ZjIzLTk5NDItYjY4ZTVmZDQ2OTQ2In0.za4yeHe82HQuDfcpqcAQpzzt42EHybCHuh9MFvHstd9BxSr6wQss3nAtIz5OSxxV"`;
216212

217213
exports[`internet > 1211 > mac > noArgs 1`] = `"ee:3f:aa:c5:bd:ca"`;
@@ -340,8 +336,6 @@ exports[`internet > 1337 > jwt > with payload.iss 1`] = `"eyJhbGciOiJSUzI1NiIsIn
340336

341337
exports[`internet > 1337 > jwt > with payload.jti 1`] = `"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3ODgzNzAsImV4cCI6MTU3NzgwMjA4MSwibmJmIjoxNTU5NzA5MTI4LCJpc3MiOiJMaXR0ZWwgYW5kIFNvbnMiLCJzdWIiOiIwNTM4OTQ1Zi00YjQxLTRjNjEtOWE1Mi1iZjI3ZGNjYzA1NzYiLCJhdWQiOiI5OGM1Mzc0ZC1hNjc3LTQyMjYtYWQzZS04ZWQ5MmZmZTZkOGIiLCJqdGkiOiJqd3QgaWQifQ.G0PJCZFas7pnDGN0GmQ3LMXl3HwuGYKPxBgzPZJfR0i5BWhYSuhlvI90GLTFxbLF"`;
342338

343-
exports[`internet > 1337 > jwt > with payload.nbf 1`] = `"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3ODgzNzAsImV4cCI6MTU3NzgwMjA4MSwibmJmIjoxNzE3NDk1NjEzLCJpc3MiOiJHb3R0bGllYiBMTEMiLCJzdWIiOiI3MDUzODk0NS1mNGI0LTQxYzYtOTFhNS0yYmYyN2RjY2MwNTciLCJhdWQiOiI2OThjNTM3NC1kYTY3LTQ3MjItYTZkMy1lOGVkOTJmZmU2ZDgiLCJqdGkiOiI4YjBkYjlmYS0yNzI2LTQ1YWItYmMwYS01ZDBjY2Y1MGI4N2EifQ.KPxBgzPZJfR0i5BWhYSuhlvI90GLTFxbLFsUFayUNkSHRgiwYbItsrFoSNtupI3N"`;
344-
345339
exports[`internet > 1337 > jwt > with payload.sub 1`] = `"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE1Nzc3ODgzNzAsImV4cCI6MTU3NzgwMjA4MSwibmJmIjoxNTU5NzA5MTI4LCJpc3MiOiJMaXR0ZWwgYW5kIFNvbnMiLCJzdWIiOiJzdWJqZWN0IiwiYXVkIjoiMDUzODk0NWYtNGI0MS00YzYxLTlhNTItYmYyN2RjY2MwNTc2IiwianRpIjoiOThjNTM3NGQtYTY3Ny00MjI2LWFkM2UtOGVkOTJmZmU2ZDhiIn0.G0PJCZFas7pnDGN0GmQ3LMXl3HwuGYKPxBgzPZJfR0i5BWhYSuhlvI90GLTFxbLF"`;
346340

347341
exports[`internet > 1337 > mac > noArgs 1`] = `"42:47:58:4f:b1:6a"`;

test/modules/internet.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,7 @@ describe('internet', () => {
142142
.it('with payload.iss', { payload: { iss: 'Acme' }, refDate })
143143
.it('with payload.sub', { payload: { sub: 'subject' }, refDate })
144144
.it('with payload.aud', { payload: { aud: 'audience' }, refDate })
145-
.it('with payload.jti', { payload: { jti: 'jwt id' }, refDate })
146-
.it('with payload.nbf', { payload: { nbf: new Date() }, refDate });
145+
.it('with payload.jti', { payload: { jti: 'jwt id' }, refDate });
147146
});
148147
});
149148

0 commit comments

Comments
 (0)