-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rewrite, plenty of new features #54
base: master
Are you sure you want to change the base?
Conversation
@relikd thanks for the PR! |
13a52cd
to
59cbc68
Compare
Not sure if I fixed it. A rebase was too complex so I merged by ignoring your commit (it contained only tab conversions anyway). In this branch there were no mixed indentation, only tabs. But I converted it all to spaces as per your request. (btw. you already had mixed indentation before my first PR). Now it is uniform. |
Also, I just looked at the diff, and I think its easier to just look at the code than the diff. There are simply too many changes 😄. But thats just my opinion. |
Thanks for the update, I will go over this in coming days. It's a huge work, so I'll need more than a quick look :)
That's right, I've noticed it! It wasn't obvious until we had some big diffs. |
Did you have any time yet to look at the PR? :) |
@relikd yes! but that's a lot to digest (4000 lines of changes!) If you have time and energy and can slice it into smaller PRs ("show iTunes Metadata", "replace zip helpers", etc), we'll get it much faster. Thank you for your contribution anyway! |
Some questions to start:
|
unfortunately that is not easily possible because the refactoring of the code structure is what makes the most changes. Otherwise I would have created multiple PRs.
CoreUI is private API and used by Apple internally. Thats why there are only header files and no source code. This framework is used to read "Assets.car" files (app icons). I placed a bunch of checks to fallback to an undistrubed execution in case the API changes (or isnt available at all which should never happen).
To read the zip content without relying on a sys-call to I have a similar fallback for the codesign sys-call (which now uses direct execution too) |
This PR supersedes #51 and includes the following:
iTunesArtwork
)Assets.car
SecCodeSigning
instead ofcodesign
sys-call--xml
flag)CFBundleShortVersionString
for some old iOS 3.2 ipa)IconFlavor
attribute for thumbnail drawing in 10.15+