Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document difference between this fork and the original version #8

Closed
marc-guenther opened this issue Nov 16, 2020 · 5 comments
Closed
Assignees

Comments

@marc-guenther
Copy link

Both this and the jbtule/cdto are available in Homebrew on Mac for example. It is entirely unclear which one to choose and what is the difference between the two.

@ealeksandrov
Copy link
Owner

Right, I need to check latest updates in jbtule/cdto and compare to this repo.

Initially I created this fork just to merge outstanding PRs and have built release ready for use. Now since original author is active again there may be less need to maintain a fork.

@ealeksandrov ealeksandrov self-assigned this Nov 16, 2020
@marc-guenther
Copy link
Author

Yea, the huge advantage of Github, it's so easy to create forks. The huge disadvantage of Github, it's so easy to create forks... :)

From what I understand from the README, you added support for iTerm and Hyper?

@ealeksandrov
Copy link
Owner

iTerm was supported by original author, but removed in v3.0 rewrite. This fork was created before removal.
Hyper support added in #1.

@marc-guenther
Copy link
Author

Ah, ok, that might make it more difficult to merge this with upstream.

I use Terminal, so I installed version 3.

@ealeksandrov
Copy link
Owner

Here is list of initial changes - jbtule#25.
Main differences from current jbtule/cdto:

  • new icon in this fork
  • support for iTerm and Hyper in this fork
  • some new settings in original
  • code refactoring applied in original

I've tried original 3.1 vs fork 2.8 on Big Sur just now and both work fine, I can't spot any significant difference in performance.

Also I recommend looking at https://github.com/Ji4n1ng/OpenInTerminal - many more integrations and features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants