Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone.min_thickness used at the wrong place #152

Open
juddidier opened this issue Oct 7, 2022 · 3 comments
Open

zone.min_thickness used at the wrong place #152

juddidier opened this issue Oct 7, 2022 · 3 comments

Comments

@juddidier
Copy link

In file <kicad_parser.py> on line #1914 (function makeZones) remove the code-sequence <+ z.min_thickness*0.5>.

To see the erroneous effect, set in KiCAD "Minimum with" of a copper zone to eg. 0.5mm. Import the .kicad_pcb in FreeCad (with AddTracks) and you get overbloated copper zones.
The comment on Lines #1908-1912 do not apply to my version of KiCAD (6.0.6). It might be that it once was an issue, but doesn't apply anymore.

@easyw
Copy link
Owner

easyw commented Oct 8, 2022

@juddidier
could you please add a failing kicad_pcb file? That would help in testing the issue.

The comment on Lines #1908-1912

this parser is a library I include in my wb...
Could you add an issue also at the original repository? fcad_pcb

@easyw
Copy link
Owner

easyw commented Oct 14, 2022

@juddidier
it should be fixed now... would you mind to check it?

@easyw easyw closed this as completed Oct 15, 2022
@juddidier
Copy link
Author

Hi easyw,

You are almost there. To my oppinion the "min_thickness" or (newly) "thickness" has nothing to do here. I have found that in the other repo issue 59 covers this.

in KiCAD the copper zone aligns exactly with the pad:
kiCAD

in FreeCAD instead the copper zone gets 0.0127mm bigger:
freecad

@easyw easyw reopened this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants