Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No display of warnings if Error List is filtered #4

Open
fsdsabel opened this issue May 18, 2018 · 3 comments
Open

No display of warnings if Error List is filtered #4

fsdsabel opened this issue May 18, 2018 · 3 comments

Comments

@fsdsabel
Copy link

When the Error List is filtered to "Build Only", the extension shows no errors or warnings.

@eberthold
Copy link
Owner

Did some investigation into this particular issue.

The IErrorList.TableControl doesn't provide the plain infos about "IntelliSense" entries when "BuildOnly" is set.
I will try to get the ITableManagerProvider and register to all ITableDataSource as a ITableDataSink to bypass this filtering.
But it's not guaranteed to work, because theres a chance that filtering takes place at ITableDataSource level.

@eberthold
Copy link
Owner

Issue is fixed in current pre release => http://vsixgallery.com/extension/97188178-f68c-49a6-9e5e-5fb99661bf09/

public roll-out in next release.

@eberthold
Copy link
Owner

The new implementation of crawling diagnostics produced some problems as well.
There are some dispatching issues to solve, and also some race conditions as it seems.

Additionally the TableDataSources are initialized the first time they are needed, so if VS starts with the active "Build Only" filter set, than IntelliSense warnings won't show until the filter is disabled at least once.

May I should investigate if there is a better way to crawl the roslyn results on another way without doing the compilation by myself in parallel.

@eberthold eberthold reopened this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants