ecere/gfx/3D/models/E3D: Fixed leaking Bitmap from second incref when adding to texturesByID

jerstlouis · jerstlouis · commit be8405cdd6f4 · 2020-07-13T19:51:35.000-04:00
- TODO: Review whether code ever gets there with a 0 ref Bitmap (Debug printout added)
diff --git a/ecere/src/gfx/3D/models/e3d/e3dRead.ec b/ecere/src/gfx/3D/models/e3d/e3dRead.ec
@@ -366,7 +366,11 @@ static void readBlocks(E3DContext ctx, File f, DisplaySystem displaySystem, E3DB
                      else
                      {
                         Bitmap bitmap = data;
-                        incref bitmap;
+#ifdef _DEBUG
+                        if(!bitmap._refCount)
+                           PrintLn("WARNING: E3D/textureID bitmap with 0 refs");
+#endif
+                        //incref bitmap;
                         ctx.curTextureID = id;
                         ctx.texturesByID[id] = bitmap;
                      }

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,11 @@ static void readBlocks(E3DContext ctx, File f, DisplaySystem displaySystem, E3DB`
`366`	`366`	`else`
`367`	`367`	`{`
`368`	`368`	`Bitmap bitmap = data;`
`369`		`- incref bitmap;`
	`369`	`+#ifdef _DEBUG`
	`370`	`+ if(!bitmap._refCount)`
	`371`	`+ PrintLn("WARNING: E3D/textureID bitmap with 0 refs");`
	`372`	`+#endif`
	`373`	`+ //incref bitmap;`
`370`	`374`	`ctx.curTextureID = id;`
`371`	`375`	`ctx.texturesByID[id] = bitmap;`
`372`	`376`	`}`