Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Commit db14c72

Browse files
Tim Etchellsjopit
Tim Etchells
authored andcommitted
Fixes to Remote Connection page and view-title button enablement (#406)
* Change placeholder values in new connection wizard Fixes eclipse-archived/codewind#1819 Signed-off-by: Tim Etchells <timetchells@ibm.com> * Fix view/title enablement Stops title buttons from appearing on other extensions' views :) Signed-off-by: Tim Etchells <timetchells@ibm.com>
1 parent 9c3018e commit db14c72

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

dev/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@
351351
],
352352
"view/title": [
353353
{
354+
"when": "view == ext.cw.explorer",
354355
"command": "%cmdID_newConnection%",
355356
"group": "navigation@0"
356357
}

dev/src/command/webview/pages/ConnectionOverviewPage.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,13 @@ export default function getConnectionInfoHtml(rp: WebviewResourceProvider, conne
7676
<div id="ingress-username-label" ${connectionExists ? "" : "style='display: none;'"}>${connectionInfo.username}</div>
7777
<input type="text" id="ingress-username" class="input-username" name="ingress-username"
7878
${connectionExists ? "style='display: none;'" : ""}
79-
value='${connectionInfo.username || "developer"}'/>
79+
placeholder="developer"
80+
value="${connectionInfo.username || ""}"/>
8081
</div>
8182
<div style="overflow: hidden; margin-top: 2em">
8283
<div id="input-password" ${connectionExists ? "style='display: none;'" : ""}>
8384
<label class="info-label" for="input-password" style="margin-left: 10px;">Password</label>
84-
<input type="password" id="ingress-password" class="input-password" name="ingress-password" placeholder="**************"/>
85+
<input type="password" id="ingress-password" class="input-password" name="ingress-password"/>
8586
</div>
8687
</div>
8788
<!--div type="button" id="test-btn" class="btn btn-prominent" ${connectionExists ? "style='display: none;'" : ""} onclick="testNewConnection()">Test</div-->

0 commit comments

Comments
 (0)