json_deserialization: _construct_model_reference is called with generic model.Referable type
#367
Labels
duplicate
This issue or pull request already exists
enhancement
Enhancement of an existing feature
sdk
Something to do with the `sdk` package
Comments
s-heppner
added
enhancement
s-heppner
pushed a commit
that referenced
this issue
Jan 15, 2025
…ce` (#337) Previously, if the `semantic_id` was a `ModelReference`, it very often had the generic `type` "`model.Referable`" instead of the actual type of the object it points to. This lead to a bug in the AASX writer, where `ConceptDescription`s were not written to the AASX, even though they existed in the `ObjectStore`. This fixes this problem by tackling three separate points: 1. In `json_deserialization.py`, we now infer the `type` of the `ModelReference` via the Reference's last `Key`. This is more of a hotfix and issue #367 tracks the creation of a better solution. 2. In `aasx.py`, an unneccessary `logger.info` call is removed, that previously cluttered the output of the writer if a `semantic_id` was not pointing to a `ConceptDescription`, which is not something worth noting. Furthermore, we improve other log messages. 3. In `examples.data._helper`, we improve the test for `semantic_id` equality, namely by comparing the `ModelReference`'s attributes explicitly, when it happens to be one, instead of relying on simple string comparision.
|
This is a duplicate of #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
_construct_model_referenceis very often called with the genericmodel.Referableastype_, instead of one of the more concret subclasses (e.g.model.Property).This means, a
model.ModelReferencethen has just the genericmodel.Referableastypeattribute, leading to problems when trying to analyze the Reference further in the code.I suggest to improve the calls of this deserialization function so that the actual type of the model object that the
ModelReferencepoints to is written to theModelReference.type.This issue was first noted in #337, where a hotfix is implemented, by inferering the type the
ModelReferencepoints to by using thelast_key_typeof the last Key in the ReferencesKeys.Once this issue is solved, we should remove the then unnecessary hotfix from the
_construct_model_referencemethod, that is marked with# TODO.The text was updated successfully, but these errors were encountered: