Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Build and Clean command fields from Launch Bar Launch Configuration, Build Settings tab #691

Closed
betamaxbandit opened this issue Feb 5, 2024 · 2 comments
Milestone

Comments

@betamaxbandit
Copy link
Contributor

The "Build command" and "Clean command", highlighted in the screenshot [1] in red (), are not relevant to this UI. It looks like they may have been a hang-over from before this was a CMake specific page.

image

This ticket is to remove them.

[1]
#683

@ewaterlander
Copy link
Contributor

I agree. They can be removed.

@jonahgraham jonahgraham added this to the 12.0.0 M2 milestone Jan 28, 2025
@jonahgraham
Copy link
Member

This has been fixed as part of #1046

Specifically, Build Command has been retained (it allows users to provide full path to CMake for example), Clean Command has been renamed to Clean Target. Also All Target has been added. This is a snapshot of what the GUI looks like: (Note that #1046 also shows the values rather than empty strings in the text boxes):

Image

Specifically these settings show up at build time like this:

Build Command:

Image

and:

Image

All Target:

Image

Clean Target (when running Project -> Clean):

Image

You can follow how the UI connects to the build by looking at the references to the build configuration property keys defined in ICMakeBuildConfiguration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants