Skip to content

Commit 38ba74e

Browse files
improve the GitHub Server subdomain isolation config description (#2667)
* improve the GitHub Server subdomain isolation config description * Update modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> --------- Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
1 parent 00bfdaf commit 38ba74e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ metadata:
3636
annotations:
3737
che.eclipse.org/oauth-scm-server: github
3838
che.eclipse.org/scm-server-endpoint: __<github_server_url>__ <2>
39-
che.eclipse.org/scm-github-disable-subdomain-isolation: "__<true_or_false>__" <3>
39+
che.eclipse.org/scm-github-disable-subdomain-isolation: true <3>
4040
type: Opaque
4141
stringData:
4242
id: __<GitHub_OAuth_Client_ID>__ <4>
4343
secret: __<GitHub_OAuth_Client_Secret>__ <5>
4444
----
4545
<1> The {prod-short} namespace. The default is `{prod-namespace}`.
4646
<2> This depends on the GitHub product your organization is using: When hosting repositories on GitHub.com or GitHub Enterprise Cloud, omit this line or enter the default `https://github.com`. When hosting repositories on GitHub Enterprise Server, enter the GitHub Enterprise Server URL.
47-
<3> This line is only added for GitHub Enterprise Server. To disable subdomain isolation, set this to `"true"`. To enable subdomain isolation, set this to `"false"`.
47+
<3> This line is only added for GitHub Enterprise Server with disabled link:https://docs.github.com/en/enterprise-server/admin/configuration/hardening-security-for-your-enterprise/enabling-subdomain-isolation#about-subdomain-isolation[subdomain isolation] option. If the subdomain isolation option is enabled on GitHub Enterprise Server, you must either omit this annotation or set it to `false`.
4848
<4> The *GitHub OAuth Client ID*.
4949
<5> The *GitHub OAuth Client Secret*.
5050

0 commit comments

Comments
 (0)