[ JDT LS ] The "Navigate File Form" has difference if compare with upstream

[Ohrimenko1988]

Note
The bug is actual for this assembly:
#10863

Reproduction Steps

• Run default "Java" stack with default "Spring" project
• Open "GreetingController.java" file
• Type in the class body

       private int privateVariable = 1;
       public int publicVariable = 1;

• Press "Ctrl" + "F12"
• In the opened form press "Ctrl" + "F12" once more
• Pay attention to icons

Expected behavior:

Observed behavior:

OS and version:
JDT LS assembly Che 6.12.0; Chrome 68; Fedora 28

[tsmaeder]

Yes, the rendering and sorting is slightly different. I think the rendering is better, because you can't override based on return type, so that info is useless here.
Need to check why the icon is "private"

[tsmaeder]

I can confirm that the visiblity is indeed ignored. This is actually a LSP problem: microsoft/language-server-protocol#98

We can fix this for the file structure window, though, since it uses a custom command.