Skip to content

Commit fab4f0e

Browse files
authored
Merge pull request #2054 from Mailaender/set-data-type
Fix a crash when importing reference chromatograms
2 parents 4439d6c + ae04aca commit fab4f0e

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

chemclipse/plugins/org.eclipse.chemclipse.ux.extension.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/dialogs/DataTypeDialog.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2021, 2023 Lablicate GmbH.
2+
* Copyright (c) 2021, 2025 Lablicate GmbH.
33
*
44
* All rights reserved. This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License v1.0
@@ -85,10 +85,10 @@ protected Control createDialogArea(Composite parent) {
8585
layout.marginRight = 10;
8686
layout.marginLeft = 10;
8787
composite.setLayout(layout);
88-
//
88+
8989
createLabel(composite);
9090
comboViewer = createComboViewer(composite);
91-
//
91+
9292
return composite;
9393
}
9494

@@ -111,11 +111,11 @@ public String getText(Object element) {
111111
if(element instanceof DataType dataType) {
112112
return dataType.name();
113113
}
114-
//
114+
115115
return null;
116116
}
117117
});
118-
//
118+
119119
combo.setToolTipText("Select a data type.");
120120
GridData gridData = new GridData(GridData.FILL_HORIZONTAL);
121121
gridData.widthHint = 150;
@@ -126,12 +126,13 @@ public String getText(Object element) {
126126
public void widgetSelected(SelectionEvent e) {
127127

128128
Object object = comboViewer.getStructuredSelection().getFirstElement();
129-
if(object instanceof DataType) {
129+
if(object instanceof DataType selectedDataType) {
130+
dataType = selectedDataType;
130131
validate();
131132
}
132133
}
133134
});
134-
//
135+
135136
comboViewer.setInput(dataTypes);
136137
return comboViewer;
137138
}

chemclipse/plugins/org.eclipse.chemclipse.ux.extension.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/swt/ChromatogramReferencesUI.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ private void createButtonImportReferences(Composite parent) {
412412
public void widgetSelected(SelectionEvent e) {
413413

414414
if(comboChromatograms != null) {
415-
DataTypeDialog dataTypeDialog = new DataTypeDialog(e.display.getActiveShell(), new DataType[]{DataType.MSD, DataType.CSD, DataType.WSD});
415+
DataTypeDialog dataTypeDialog = new DataTypeDialog(e.display.getActiveShell(), new DataType[]{DataType.MSD, DataType.CSD, DataType.WSD, DataType.VSD});
416416
if(IDialogConstants.OK_ID == dataTypeDialog.open()) {
417417
DataType dataType = dataTypeDialog.getDataType();
418418
InputWizardSettings inputWizardSettings = InputWizardSettings.create(Activator.getDefault().getPreferenceStore(), dataType);

0 commit comments

Comments
 (0)