clang tidy + CMakeLists.txt fix

Author: rex-schilasky

app/sys/sys_core/src/connection/remote_connection.cpp

@@ -144,11 +144,10 @@ namespace eCAL
         }
       }
 
-      eCAL::ServiceResponseVecT service_response_vec;
       constexpr int timeout_ms = 1000;
 
       auto client_instances = sys_client_service_.GetClientInstances();
-      for (auto& client_instance : client_instances)
+        for (auto& client_instance : client_instances)
       {
         // TODO: We need to filter for pid as well in the future?
         // Currently empty hostname means "all hosts"

lang/python/core/src/ecal_wrap.cxx

@@ -979,7 +979,7 @@ namespace
       PyDict_SetItemString(topicDict, "tdatatype_descriptor", val); Py_DECREF(val);
 
       PyObject* layerList = PyList_New(0);
-      for (auto layer : topic.transport_layer)
+      for (const auto& layer : topic.transport_layer)
       {
         PyObject* layerDict = PyDict_New();
         PyList_Append(layerList, layerDict); Py_DECREF(layerDict);
@@ -1144,7 +1144,7 @@ PyObject* mon_monitoring(PyObject* /*self*/, PyObject* /*args*/)
         PyObject* methodsDict = PyDict_New();
         PyDict_SetItemString(serviceDict, "methods", methodsDict); Py_DECREF(methodsDict);
 
-        for (const auto method : service.methods)
+        for (const auto& method : service.methods)
         {
           val = Py_BuildValue("s", method.method_name.c_str());
           PyDict_SetItemString(methodsDict, "mname", val); Py_DECREF(val);
@@ -1207,7 +1207,7 @@ PyObject* mon_monitoring(PyObject* /*self*/, PyObject* /*args*/)
         PyObject* methodsDict = PyDict_New();
         PyDict_SetItemString(clientDict, "methods", methodsDict); Py_DECREF(methodsDict);
 
-        for (const auto method : client.methods)
+        for (const auto& method : client.methods)
         {
           val = Py_BuildValue("s", method.method_name.c_str());
           PyDict_SetItemString(methodsDict, "mname", val); Py_DECREF(val);

serialization/protobuf/protobuf/CMakeLists.txt

@@ -77,7 +77,7 @@ target_sources(protobuf_core
     FILES
       include/ecal/msg/protobuf/client.h
       include/ecal/msg/protobuf/client_instance.h
-      include/ecal/msg/protobuf/client_types_response.h
+      include/ecal/msg/protobuf/client_typed_response.h
       include/ecal/msg/protobuf/dynamic_json_subscriber.h
       include/ecal/msg/protobuf/dynamic_publisher.h
       include/ecal/msg/protobuf/dynamic_subscriber.h

serialization/protobuf/protobuf/include/ecal/msg/protobuf/client.h

@@ -77,7 +77,20 @@ namespace eCAL
       {
       }
 
-      // Delete copy constructor and assignment operator.
+      /**
+       * @brief Destructor.
+      **/
+      ~CServiceClient() override = default;
+
+      /**
+       * @brief CServiceClients are non-movable.
+      **/
+      CServiceClient(CServiceClient&& other) = delete;
+      CServiceClient& operator=(CServiceClient&& other) = delete;
+
+      /**
+       * @brief CServiceClients are non-copyable.
+      **/
       CServiceClient(const CServiceClient&) = delete;
       CServiceClient& operator=(const CServiceClient&) = delete;
 
@@ -119,7 +132,7 @@ namespace eCAL
       std::pair<bool, TMsgServiceResponseVecT<ResponseT>> CallWithResponse( const std::string& method_name_, const google::protobuf::Message& request_,
         int timeout_ = DEFAULT_TIME_ARGUMENT) const
       {
-        bool all_success = true;
+        bool overall_success = true;
         TMsgServiceResponseVecT<ResponseT> responses;
 
         // Get all client instances.
@@ -130,10 +143,10 @@ namespace eCAL
           responses.push_back(std::move(ret.second));
           if (!ret.first)
           {
-            all_success = false;
+            overall_success = false;
           }
         }
-        return std::pair<bool, TMsgServiceResponseVecT<ResponseT>>(all_success, responses);
+        return std::pair<bool, TMsgServiceResponseVecT<ResponseT>>(overall_success, responses);
       }
 
       /**
@@ -149,7 +162,7 @@ namespace eCAL
       std::pair<bool, ServiceResponseVecT> CallWithResponse(const std::string& method_name_, const google::protobuf::Message& request_,
         int timeout_ = DEFAULT_TIME_ARGUMENT) const
       {
-        bool all_success = true;
+        bool overall_success = true;
         ServiceResponseVecT responses;
 
         // Get all client instances.
@@ -160,10 +173,10 @@ namespace eCAL
           responses.push_back(std::move(ret.second));
           if (!ret.first)
           {
-            all_success = false;
+            overall_success = false;
           }
         }
-        return std::pair<bool, ServiceResponseVecT>(all_success, responses);
+        return std::pair<bool, ServiceResponseVecT>(overall_success, responses);
       }
 
       /**
@@ -268,7 +281,7 @@ namespace eCAL
         U temp_instance;
         const google::protobuf::ServiceDescriptor* service_descriptor = temp_instance.GetDescriptor();
 
-        if (!service_descriptor)
+        if (service_descriptor == nullptr)
         {
           throw std::runtime_error("Failed to retrieve service descriptor.");
         }
@@ -280,10 +293,10 @@ namespace eCAL
         for (int i = 0; i < service_descriptor->method_count(); ++i)
         {
           const google::protobuf::MethodDescriptor* method_descriptor = service_descriptor->method(i);
-          std::string method_name = method_descriptor->name();
+          const std::string& method_name = method_descriptor->name();
 
-          std::string request_type_name = method_descriptor->input_type()->name();
-          std::string response_type_name = method_descriptor->output_type()->name();
+          const std::string& request_type_name = method_descriptor->input_type()->name();
+          const std::string& response_type_name = method_descriptor->output_type()->name();
 
           std::string request_type_descriptor;
           std::string response_type_descriptor;

serialization/protobuf/protobuf/include/ecal/msg/protobuf/client_instance.h

@@ -55,7 +55,7 @@ namespace eCAL
     class CClientInstance
     {
     public:
-      // Constructors
+      // Constructor
       CClientInstance(eCAL::CClientInstance&& base_instance_) noexcept
         : m_instance(std::move(base_instance_))
       {

serialization/protobuf/samples/services/math_client/src/math_client.cpp

@@ -84,7 +84,7 @@ int main()
   eCAL::Initialize("math client");
 
   // Create a math service client using the protobuf service type MathService.
-  eCAL::protobuf::CServiceClient<MathService> math_client(OnClientState);
+  const eCAL::protobuf::CServiceClient<MathService> math_client(OnClientState);
 
   // Wait until the client is connected to at least one service.
   while (eCAL::Ok() && !math_client.IsConnected())

serialization/protobuf/samples/services/ping_client/src/ping_client.cpp

@@ -33,7 +33,7 @@ int main()
   eCAL::Initialize("ping client");
 
   // create ping service client
-  eCAL::protobuf::CServiceClient<PingService> ping_client("ping service");
+  const eCAL::protobuf::CServiceClient<PingService> ping_client("ping service");
 
   // waiting for service
   while (eCAL::Ok() && !ping_client.IsConnected())
@@ -56,7 +56,7 @@ int main()
       {
         std::cout << std::endl << "PingService::Ping method called with message : " << ping_request.message() << std::endl;
 
-        for (auto service_response : ping_response.second)
+        for (const auto& service_response : ping_response.second)
         {
           switch (service_response.call_state)
           {