Skip to content

Commit 1f040da

Browse files
fix: use correct dcat:endpointURL spelling (#255)
1 parent ab773a1 commit 1f040da

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

DEPENDENCIES

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ maven/mavencentral/com.google.guava/guava/33.3.1-jre, Apache-2.0 AND CC0-1.0 AND
4141
maven/mavencentral/com.google.guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava, Apache-2.0, approved, CQ22657
4242
maven/mavencentral/com.google.j2objc/j2objc-annotations/3.0.0, Apache-2.0, approved, #13676
4343
maven/mavencentral/com.google.protobuf/protobuf-java/3.25.3, BSD-3-Clause, approved, clearlydefined
44-
maven/mavencentral/com.nimbusds/nimbus-jose-jwt/9.41.2, , restricted, clearlydefined
44+
maven/mavencentral/com.nimbusds/nimbus-jose-jwt/9.41.2, Apache-2.0, approved, clearlydefined
4545
maven/mavencentral/com.puppycrawl.tools/checkstyle/10.18.2, LGPL-2.1-or-later AND (Apache-2.0 AND LGPL-2.1-or-later) AND Apache-2.0, approved, #16060
4646
maven/mavencentral/com.squareup.okhttp3/okhttp-dnsoverhttps/4.12.0, Apache-2.0, approved, #11159
4747
maven/mavencentral/com.squareup.okhttp3/okhttp/4.12.0, Apache-2.0, approved, #15227

core/federated-catalog-core/src/main/java/org/eclipse/edc/catalog/cache/query/DspCatalogRequestAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ private CompletableFuture<Catalog> expandCatalog(Catalog rootCatalog) {
100100
.map(CatalogUpdateResponse::getCatalog);
101101

102102
var datasets = ofNullable(partitions.get(Dataset.class))
103-
.map(ds -> new ArrayList<>(ds))
103+
.map(ArrayList::new)
104104
.orElseGet(ArrayList::new);
105105
expandedSubCatalogs.forEach(datasets::add);
106106
return completedFuture(copy(rootCatalog, datasets).build());

core/federated-catalog-core/src/main/java/org/eclipse/edc/catalog/transform/JsonObjectToDataServiceTransformer.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import static org.eclipse.edc.jsonld.spi.PropertyAndTypeNames.DCAT_ENDPOINT_DESCRIPTION_ATTRIBUTE;
2626
import static org.eclipse.edc.jsonld.spi.PropertyAndTypeNames.DCAT_ENDPOINT_URL_ATTRIBUTE;
27+
import static org.eclipse.edc.jsonld.spi.PropertyAndTypeNames.DCAT_ENDPOINT_URL_OLD_ATTRIBUTE;
2728

2829
/**
2930
* Converts from a DCAT data service as a {@link JsonObject} in JSON-LD expanded form to a {@link DataService}.
@@ -45,7 +46,7 @@ public JsonObjectToDataServiceTransformer() {
4546
}
4647

4748
private void transformProperties(String key, JsonValue value, DataService.Builder builder, TransformerContext context) {
48-
if (DCAT_ENDPOINT_URL_ATTRIBUTE.equals(key)) {
49+
if (DCAT_ENDPOINT_URL_ATTRIBUTE.equals(key) || DCAT_ENDPOINT_URL_OLD_ATTRIBUTE.equals(key)) {
4950
transformString(value, builder::endpointUrl, context);
5051
} else if (DCAT_ENDPOINT_DESCRIPTION_ATTRIBUTE.equals(key)) {
5152
transformString(value, builder::endpointDescription, context);

system-tests/component-tests/src/test/resources/catalog.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"@id": "9789e27e-8200-4f65-b1c6-45d9938dc698",
2+
"@id": "sub-catalog-id",
33
"@type": "dcat:Catalog",
44
"dcat:dataset": [
55
{
6-
"@id": "normal-asset-a873f2be-295e-4d03-af1c-0e15c1363627",
6+
"@id": "subcatalog-asset-a873f2be-295e-4d03-af1c-0e15c1363627",
77
"@type": "dcat:Dataset",
88
"odrl:hasPolicy": {
99
"@id": "ODkzNGY3MzEtYzdmMy00N2NiLTlmM2UtNGU1ZDljOGNjNzU3:bm9ybWFsLWFzc2V0LWE4NzNmMmJlLTI5NWUtNGQwMy1hZjFjLTBlMTVjMTM2MzYyNw==:OGZhMzc3ODktOTZlYS00ZGQ1LWIyZjktNjYzNTQwOWZlNTUw",
@@ -26,7 +26,7 @@
2626
"@id": "5cc832e4-9b77-412b-a21e-7d5b49516f2c",
2727
"@type": "dcat:DataService",
2828
"dcat:endpointDescription": "dspace:connector",
29-
"dcat:endpointUrl": "http://localhost:55229/protocol",
29+
"dcat:endpointURL": "http://localhost:55229/protocol",
3030
"dct:terms": "dspace:connector",
3131
"dct:endpointUrl": "http://localhost:55229/protocol"
3232
},

system-tests/component-tests/src/test/resources/catalog_of_catalogs.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"@id": "9789e27e-8200-4f65-b1c6-45d9938dc698",
2+
"@id": "root-catalog-id",
33
"@type": "dcat:Catalog",
44
"dcat:dataset": [
55
{
@@ -37,7 +37,7 @@
3737
"dcat:service": {
3838
"@id": "Y2F0YWxvZy1hc3NldC01YTc0ODJiZC1hMmE4LTQyNDgtYThmYS0zNTNjYjFkMTRkZjc=",
3939
"@type": "dcat:DataService",
40-
"dcat:endpointUrl": "http://quizzqua.zz/buzz",
40+
"dcat:endpointURL": "http://quizzqua.zz/buzz",
4141
"dct:endpointUrl": "http://quizzqua.zz/buzz"
4242
},
4343
"isCatalog": true,
@@ -50,7 +50,7 @@
5050
"@id": "5cc832e4-9b77-412b-a21e-7d5b49516f2c",
5151
"@type": "dcat:DataService",
5252
"dcat:endpointDescription": "dspace:connector",
53-
"dcat:endpointUrl": "http://localhost:55229/protocol",
53+
"dcat:endpointURL": "http://localhost:55229/protocol",
5454
"dct:terms": "dspace:connector",
5555
"dct:endpointUrl": "http://localhost:55229/protocol"
5656
},

0 commit comments

Comments
 (0)