-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add federated catalog samples for an embedded and a standalone federated catalog #342
feat: add federated catalog samples for an embedded and a standalone federated catalog #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide automated tests on the system-tests
module that ensure the samples are working correctly, as done for the other samples
6897586
to
246b424
Compare
Automated tests have been added for the samples. |
.../src/test/java/org/eclipse/edc/samples/federated/catalog/FederatedCatalog01embeddedTest.java
Outdated
Show resolved
Hide resolved
...esolver/src/main/java/org/eclipse/edc/sample/extension/fc/CatalogNodeDirectoryExtension.java
Outdated
Show resolved
Hide resolved
...ed-node-resolver/src/main/java/org/eclipse/edc/sample/extension/fc/CatalogNodeDirectory.java
Outdated
Show resolved
Hide resolved
The pipeline tests are experiencing unpredictable failures. In the latest commit, one of the tests in Probable cause: Solution: @ndr-brt, @paullatzelsperger could you please confirm if I have understood this correctly or missed something? If this is indeed a valid issue, then I would like to open an issue on this. |
this is definitely an issue that needs to be fixed in the FederatedCatalog repo, would you mind to open an issue? (end eventually provide a PR to fix it?)
that's correct, but we need a workaround right here to make it pass, like increasing the timeout or increasing the "period seconds" setting in the FC runtime configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyway, it just passed, so LGTM and please open an issue in the FCC repository about the thread shutdown. I guess tests will remain flake until the fix will be rolled out in a new version. Given that this is the Samples repos I guess we can bear with that.
I will open an issue and take care of the fix.
I will leave it for now, as the current commit just passed. And will make necessary adjustments in future commits. |
What this PR changes/adds
This PR adds a new module
federated-catalog
, which includes the following samples,fc-00-basic
: includes preparations for the later Federated Catalog samplesfc-01-embedded
: demonstration of a federated catalog, embedded in a connector.fc-02-standalone
: demonstrates the implementation of a standalone catalog.Why it does that
To illustrate how we can implement different types of Federated Catalogs, e.g embedded and standalone.
Further notes
Projects and libraries have been added in settings.gradle.kts, and gradle/libs.versions.toml.
Linked Issue(s)
Contributes to #296
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.