Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the UnsupportedOperationException in case of descriptor removal #472

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 18, 2024

If removal of the errornous descriptor failed this can have different reasons:

  1. it was never added because the target is not capable of downloading 2) the repository does not support removal of descriptors 3) some bug in the implementation

in any case we want to report the original error an not an error that says we can't remove the descriptor.

If removal of the errornous descriptor failed this can have different
reasons:

1) it was never added because the target is not capable of downloading
2) the repository does not support removal of descriptors
3) some bug in the implementation

in any case we want to report the original error an not an error that
says we can't remove the descriptor.
Copy link

Test Results

    9 files  ±0      9 suites  ±0   29m 9s ⏱️ - 4m 14s
2 183 tests ±0  2 179 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 639 runs  ±0  6 628 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 10a5c9a. ± Comparison against base commit 57ecc5a.

@laeubi laeubi requested a review from merks February 20, 2024 12:42
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems adding more logic is the only way to track down why we are removing a descriptor from an implementation that does not support removal at all.

@laeubi
Copy link
Member Author

laeubi commented Feb 20, 2024

+1 form me as PL for RC1 thus merging

@laeubi laeubi merged commit 151d95b into eclipse-equinox:master Feb 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants