Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ProvisioningContext.FOLLOW_ARTIFACT_REPOSITORY_REFERENCES public to avoid duplication #506

Conversation

tivervac
Copy link
Contributor

@tivervac tivervac commented Apr 25, 2024

It was duplicated in DirectorApplication, making it hard to follow the property around the code.

The original inspiration for this came from #505

@merks
Copy link
Contributor

merks commented Apr 25, 2024

@laeubi

The service segment has been incremented twice in this release cycle:

image

The @since in this PR is not okay because this was added for 2.10.200 not for 2.10. So we really should increase this to 2.11.0.

Also the package constraint where this constant is used says 2.2.0 because that's the current version of the package, but that version hasn't changed here and so that version of the package does not necessary have the public constant. So probably that should be increased too, probably to 2.11.0 like the bundle.

@laeubi
Copy link
Member

laeubi commented Apr 25, 2024

@merks I think the package should become 2.3.0 now according to semver as this is a client compatible change and I don't see why it must be aligned with the bundle version (what we didn't do before).

@tivervac
Copy link
Contributor Author

Since I'm just trying to resolve the reference issue in general, I've added the isEnabled changes to this PR. If you prefer, I can split it up into two PRs.

@tivervac tivervac force-pushed the public_follow_artifact_repository_references branch from 52d0189 to 2dd0293 Compare April 25, 2024 09:34
@tivervac
Copy link
Contributor Author

I've bumped p2.engine to 2.3.0 from 2.2.0. I'm holding off on the 2.11 story until consensus is achieved. Personally, I expect that 2.11 bundle is necessary, but that a 2.3 package suffices.

… to avoid duplication

It was duplicated in DirectorApplication, making it hard to follow the property
around the code

zever

aiorn
This abstracts the bit flag checking for repository
references.
@tivervac tivervac force-pushed the public_follow_artifact_repository_references branch from 2dd0293 to 8c2cddd Compare April 25, 2024 09:39
@merks
Copy link
Contributor

merks commented Apr 25, 2024

I've bumped p2.engine to 2.3.0 from 2.2.0. I'm holding off on the 2.11 story until consensus is achieved. Personally, I expect that 2.11 bundle is necessary, but that a 2.3 package suffices.

I’m good with that.

Copy link

Test Results

    9 files  ±0      9 suites  ±0   30m 35s ⏱️ +9s
2 196 tests ±0  2 192 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 678 runs  ±0  6 667 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 8c2cddd. ± Comparison against base commit 0e4707e.

@laeubi laeubi merged commit 4426f86 into eclipse-equinox:master Apr 25, 2024
11 checks passed
@laeubi
Copy link
Member

laeubi commented Apr 25, 2024

@tivervac thanks for the imropvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants