Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hono device registry JDBC native image 2.5.0 missing #3604

Closed
harism opened this issue Jan 18, 2024 · 3 comments
Closed

Hono device registry JDBC native image 2.5.0 missing #3604

harism opened this issue Jan 18, 2024 · 3 comments
Assignees
Labels

Comments

@harism
Copy link
Contributor

harism commented Jan 18, 2024

In relation to closed issue #3555 --

Now that the JDBC device registry native build has been executing as part of native integration tests, would it be ok to add it to published native images also;
hono/push_hono_images.sh

Line 38 in 6ca0633

     hono-service-device-registry-mongodb-native" 

Currently this image 2.5.0 version is still missing from Docker Hub, and I didn't think of this while making the functional changes.

@sophokles73
Copy link
Contributor

I had noticed as well when I pushed the images last night ;-)
Firts, we had to have the Eclipse Foundation create the corresponding Docker Hub repository for the image. Now we can push the image.

Feel free to create a corresponding PR ... 👍

@harism
Copy link
Contributor Author

harism commented Jan 18, 2024

I am not 100% sure how I should have handled it to make the same change in master and 2.5.x branches and I can change this if the current 2 separate PRs one for each branch is not the wanted way.

@sophokles73
Copy link
Contributor

closed via #3606 and #3607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants