Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CompilerOptions.OPTION_InlineJsr & CompilerOptions.inlineJsrBytecode in 4.34 release #2759

Closed
Tracked by #2761
iloveeclipse opened this issue Jul 25, 2024 · 0 comments · Fixed by #2923
Closed
Tracked by #2761

Remove CompilerOptions.OPTION_InlineJsr & CompilerOptions.inlineJsrBytecode in 4.34 release #2759

iloveeclipse opened this issue Jul 25, 2024 · 0 comments · Fixed by #2923
Assignees
@iloveeclipse
Labels
enhancement New feature or request
Milestone
4.34 M1

Comments

@iloveeclipse
Copy link
Member

CompilerOptions.OPTION_InlineJsr & CompilerOptions.inlineJsrBytecode do not make any sense after #2551, they are deprecated now in 4.33 and should be removed in 4.34.

It is not API, so we are free to remove at any release, the only reason they are not removed is that we are bit late with #2551 in M2 and ideally we should avoid breaking clients that might reference these symbols late in release process.
@iloveeclipse iloveeclipse added the enhancement New feature or request label Jul 25, 2024
@iloveeclipse iloveeclipse mentioned this issue Jul 25, 2024
Open
12 tasks
iloveeclipse added a commit that referenced this issue Sep 5, 2024
@iloveeclipse
Remove CompilerOptions.OPTION_InlineJsr & inlineJsrBytecode
1ce20a2 
Fixes #2759
@iloveeclipse iloveeclipse mentioned this issue Sep 5, 2024
Merged
iloveeclipse added a commit that referenced this issue Sep 5, 2024
@iloveeclipse
Remove CompilerOptions.OPTION_InlineJsr & inlineJsrBytecode
7b15979 
Fixes #2759
@iloveeclipse iloveeclipse self-assigned this Sep 5, 2024
@iloveeclipse iloveeclipse added this to the 4.34 M1 milestone Sep 5, 2024
@iloveeclipse iloveeclipse mentioned this issue Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.34 M1
Development

Successfully merging a pull request may close this issue.

Remove CompilerOptions.OPTION_InlineJsr & inlineJsrBytecode eclipse-jdt/eclipse.jdt.core
1 participant
@iloveeclipse