Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECJ throws false-positive "Package collides with type" on Windows (case-insensitive compiler) #985

Open
loetifuss opened this issue Apr 18, 2023 · 1 comment · May be fixed by #3057
Open

ECJ throws false-positive "Package collides with type" on Windows (case-insensitive compiler) #985

loetifuss opened this issue Apr 18, 2023 · 1 comment · May be fixed by #3057
Labels
good first issue Good for newcomers

Comments

@loetifuss
Copy link

When compiling two projects I'm getting false-positive error messages:

The package com.bla.x collides with a type

Suppose I have a package "com.foo" containing a class "Test.java" in project A. Project B contains a package "com.foo.test" and references project A.
If the compiler is passed an instance of "javax.tools.ForwardingJavaFileManager" it will throw the following error on compilation of "B":

The package com.foo.test collides with a type

This is because "EclipseFileManager" uses "java.io.File.exists()" to check if a package already exists. This check however is case-insensitive on Windows so it collides with the type "com.foo.Test.java" which is a false-positive.

BTW: When passing an instance of "EclipseFileManager" instead of "javax.tools.ForwardingJavaFileManager" the code will compile fine. This is because EclipseCompiler contains several "instanceof StandardJavaFileManager" checks.
@loetifuss
Copy link
Author

Here is a small self-contained example reproducing the issue:

reproducer.zip

@mpalat mpalat added the good first issue Good for newcomers label Apr 20, 2023
@jjohannes jjohannes mentioned this issue May 24, 2023
Closed
12 tasks
jjohannes added a commit to jjohannes/gradle that referenced this issue Jun 5, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
6db43e7 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Jul 5, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
e4ce3c6 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Jul 6, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
d63f9d3 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Jul 10, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
56c8dfb 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Aug 3, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
f4d83ad 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Sep 19, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
1407029 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Sep 19, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
29adb79 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Oct 9, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
e5801b6 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Oct 31, 2023
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
d080067 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit to jjohannes/gradle that referenced this issue Apr 3, 2024
@jjohannes
Let 'GradleStandardJavaFileManager' implement 'StandardJavaFileManager'
798d88f 
...by forwarding all methods to the wrapped file manager.
This gives it more robustness when running with custom compiler and
file manager implementation. In particular, it avoids hitting the
following issue with the Eclipse compiler:
eclipse-jdt/eclipse.jdt.core#985

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
nettozahler added a commit to nettozahler/eclipse.jdt.core that referenced this issue Oct 7, 2024
@nettozahler
Bugfix for eclipse-jdt#985: ECJ throws false-positive "Package collid…
fb646a5 
…es with type".
@nettozahler nettozahler linked a pull request Oct 7, 2024 that will close this issue
Open
3 tasks
nettozahler added a commit to nettozahler/eclipse.jdt.core that referenced this issue Oct 10, 2024
@nettozahler
Bugfix for eclipse-jdt#985: ECJ throws false error "Package collides …
94bb454 
…with type".
nettozahler added a commit to nettozahler/eclipse.jdt.core that referenced this issue Nov 2, 2024
@nettozahler
Bugfix for eclipse-jdt#985: ECJ throws false error "Package collides …
1cd66db 
…with type".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@mpalat @loetifuss