Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 #1792

carstenartur · 2024-11-09T11:34:48Z

There is a test for "Add quick assist to split case expressions"

https://bugs.eclipse.org/bugs/show_bug.cgi?id=545261

https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/139182

Not sure if the test itself has a bug this is what I get (can reproduce locally)

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
at java.base/java.util.Objects.checkIndex(Objects.java:359)
at java.base/java.util.ArrayList.get(ArrayList.java:427)
at org.eclipse.jdt.ui.tests.quickfix.AssistQuickFixTest12.testSplitSwitchCaseLabelRuleStatement(AssistQuickFixTest12.java:161)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:42)
at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:73)
at org.junit.platform.suite.engine.SuiteLauncher.execute(SuiteLauncher.java:63)
at org.junit.platform.suite.engine.SuiteTestDescriptor.execute(SuiteTestDescriptor.java:150)
at org.junit.platform.suite.engine.SuiteTestEngine.lambda$execute$0(SuiteTestEngine.java:73)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at org.junit.platform.suite.engine.SuiteTestEngine.execute(SuiteTestEngine.java:73)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:73)
at org.junit.platform.suite.engine.SuiteLauncher.execute(SuiteLauncher.java:63)
at org.junit.platform.suite.engine.SuiteTestDescriptor.execute(SuiteTestDescriptor.java:150)
at org.junit.platform.suite.engine.SuiteTestEngine.lambda$execute$0(SuiteTestEngine.java:73)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at org.junit.platform.suite.engine.SuiteTestEngine.execute(SuiteTestEngine.java:73)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:56)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:184)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:148)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:122)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.apache.maven.surefire.api.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:137)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:148)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:88)
at org.eclipse.tycho.surefire.osgibooter.OsgiSurefireBooter.run(OsgiSurefireBooter.java:140)
at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication$1.run(AbstractUITestApplication.java:42)
at org.eclipse.e4.ui.internal.workbench.swt.E4Testable.lambda$1(E4Testable.java:127)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5042)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4522)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:663)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:570)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:178)
at org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:34)
at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:129)
at org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:44)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:208)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:143)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:439)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:271)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
at org.eclipse.equinox.launcher.Main.run(Main.java:1481)
at org.eclipse.equinox.launcher.Main.main(Main.java:1454)

Could this have something to do with
eclipse-jdt/eclipse.jdt.core#3264
?

Here a link to a failing build
https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/PR-1725/8/testReport/junit/(root)/AutomatedSuite%20QuickFixTestSuite%20AssistQuickFixTest12/testSplitSwitchCaseLabelRuleStatement/

carstenartur · 2024-11-10T12:25:00Z

@srikanth-sankaran could this have something to do with latest switch related changes in core?

srikanth-sankaran · 2024-11-10T13:08:01Z

I'll take a look. Do you mean a test is failing or the build itself failed ??

carstenartur · 2024-11-10T13:22:44Z

I'll take a look. Do you mean a test is failing or the build itself failed ??

A test is failing - failing hhe build to run through

org.eclipse.jdt.ui.tests.quickfix.AssistQuickFixTest12.testSplitSwitchCaseLabelRuleStatement(AssistQuickFixTest12.java:161)

srikanth-sankaran · 2024-11-10T15:59:11Z

There have been lots of changes recently in ECJ wrt compiling switch - but I when I grab the test case from here that snippet compiles fine and in an SDK instance launched with latest jdt-core (as in master/HEAD) plugins but from a dev ide with these versions Version: 2024-12 (4.34) Build id: I20241103-1800 I am able to split the cases without any issue.

So I will wait for @noopur2507 to triage this and raise a defect against jdt-core if called for.

srikanth-sankaran · 2024-11-10T16:05:32Z

A test is failing - failing hhe build to run through

Thanks, I have adjusted the title accordingly.

srikanth-sankaran · 2024-11-10T16:14:45Z

I downloaded :

Eclipse SDK

Version: 2024-12 (4.34)
Build id: I20241110-0600

and with this snippet pasted in:

package test;
			public class Cls {
			    public static void foo(Day day) {
			        String weekDayOrEnd = switch (day) {
			            case SATURDAY, SUNDAY -> "Weekend";
			            case MONDAY, TUESDAY, WEDNESDAY -> "Weekday";
			            case THURSDAY, FRIDAY -> "Weekday";
			        };
			    }
			}
			
			enum Day {
			    MONDAY, TUESDAY, WEDNESDAY, THURSDAY, FRIDAY, SATURDAY, SUNDAY;
			}

I am able to ask for the last multi label case to be split and have it split (with some messed up formatting though)

So don't know why exactly the test is failing. Will wait for a jdt-ui person to investigate. Thanks

srikanth-sankaran · 2024-11-11T08:37:25Z

Looks like @noopur2507 is away - is anyone else able to triage this ? @jjohnstn perhaps ?

jarthana · 2024-11-11T09:15:40Z

The test is crashing because it's simply trying to get the proposal at 0 without asserting the size. So, it appears the test was expecting > 0 proposal, but not getting any.

I20241108-1800 eclipse-jdt#1792

jarthana · 2024-11-11T11:09:16Z

OK, the test was wrong as it was testing switch expressions at compliance 12 instead of 14. It was working because the SourceElementParser in jdt.core allowed it at compliance 12. I have a patch to address this.

I20241108-1800 eclipse-jdt#1792

#1794

carstenartur changed the title ~~build is broken because of switch processing test~~ build is broken because of switch assist test Nov 9, 2024

srikanth-sankaran changed the title ~~build is broken because of switch assist test~~ Splitting multiple cases in switch rule fails with IOOBE in the latest I Build Nov 10, 2024

jukzi changed the title ~~Splitting multiple cases in switch rule fails with IOOBE in the latest I Build~~ Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 Nov 11, 2024

jukzi added regression Regression defect test junit test related things labels Nov 11, 2024

jarthana added a commit to jarthana/eclipse.jdt.ui that referenced this issue Nov 11, 2024

Splitting multiple cases in switch rule fails with IOOBE since

bd4114b

I20241108-1800 eclipse-jdt#1792

jarthana mentioned this issue Nov 11, 2024

Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 #1792 #1794

Merged

3 tasks

jarthana added a commit to jarthana/eclipse.jdt.ui that referenced this issue Nov 11, 2024

Splitting multiple cases in switch rule fails with IOOBE since

0c89238

I20241108-1800 eclipse-jdt#1792

jarthana closed this as completed in #1794 Nov 11, 2024

jarthana added a commit that referenced this issue Nov 11, 2024

Upgrade the testcase to compliance 14 since switch expressions #1792

2886912

#1794

jarthana self-assigned this Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 #1792

Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 #1792

carstenartur commented Nov 9, 2024 •

edited

Loading

carstenartur commented Nov 10, 2024

srikanth-sankaran commented Nov 10, 2024

carstenartur commented Nov 10, 2024

srikanth-sankaran commented Nov 10, 2024 •

edited

Loading

srikanth-sankaran commented Nov 10, 2024

srikanth-sankaran commented Nov 10, 2024

srikanth-sankaran commented Nov 11, 2024

jarthana commented Nov 11, 2024

jarthana commented Nov 11, 2024

Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 #1792

Splitting multiple cases in switch rule fails with IOOBE since I20241108-1800 #1792

Comments

carstenartur commented Nov 9, 2024 • edited Loading

carstenartur commented Nov 10, 2024

srikanth-sankaran commented Nov 10, 2024

carstenartur commented Nov 10, 2024

srikanth-sankaran commented Nov 10, 2024 • edited Loading

srikanth-sankaran commented Nov 10, 2024

srikanth-sankaran commented Nov 10, 2024

srikanth-sankaran commented Nov 11, 2024

jarthana commented Nov 11, 2024

jarthana commented Nov 11, 2024

carstenartur commented Nov 9, 2024 •

edited

Loading

srikanth-sankaran commented Nov 10, 2024 •

edited

Loading