Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eclipse-jkube/jkube
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 406b0377a942ff10b23dc4278024281b45dfa707
Choose a base ref
..
head repository: eclipse-jkube/jkube
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1d38e36f800a090717bd6696c04c77bd1181c883
Choose a head ref
Original file line number Diff line number Diff line change
@@ -88,7 +88,6 @@
import static org.eclipse.jkube.kit.common.util.BuildReferenceDateUtil.getBuildTimestampFile;
import static org.eclipse.jkube.kit.config.service.kubernetes.KubernetesClientUtil.updateResourceConfigNamespace;
import static org.eclipse.jkube.kit.config.service.kubernetes.SummaryServiceUtil.handleExceptionAndSummary;
import static org.eclipse.jkube.kit.config.service.kubernetes.SummaryServiceUtil.printSummary;
import static org.eclipse.jkube.kit.config.service.kubernetes.SummaryServiceUtil.printSummaryIfLastExecuting;
import static org.eclipse.jkube.maven.plugin.mojo.build.AbstractJKubeMojo.DEFAULT_LOG_PREFIX;

Original file line number Diff line number Diff line change
@@ -159,7 +159,7 @@ public File getKubernetesManifest() {
public void executeInternal() throws MojoExecutionException {
try (KubernetesClient kubernetes = jkubeServiceHub.getClient()) {
applyService = jkubeServiceHub.getApplyService();
initServices(kubernetes);
initServices();

URL masterUrl = kubernetes.getMasterUrl();
final File manifest = getManifest(kubernetes);
@@ -203,7 +203,7 @@ protected void applyEntities(final KubernetesClient kubernetes, String fileName,
applyService.applyEntities(fileName, entities, serviceLogger, serviceUrlWaitTimeSeconds);
}

protected void initServices(KubernetesClient kubernetes) {
protected void initServices() {
log.debug("No services required in ApplyMojo");
}