Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesHelmTask: Implement k8s:helm equivalent functionality k8sHelm for Kubernetes Gradle Plugin #1052

Closed
4 tasks done
manusa opened this issue Oct 20, 2021 · 4 comments · Fixed by #1071
Closed
4 tasks done

KubernetesHelmTask: Implement k8s:helm equivalent functionality k8sHelm for Kubernetes Gradle Plugin #1052

manusa opened this issue Oct 20, 2021 · 4 comments · Fixed by #1071
Assignees
@rohanKanojia
Labels
component/gradle-plugin Related to the Gradle Plugins
Milestone
1.5.0

Comments

@manusa
Copy link
Member

manusa commented Oct 20, 2021 •
edited
Loading

Description

Child of #31
Blocked by #1029

Port HelmMojo from maven plugins to KubernetesHelmTask

  • Any functionality present in maven plugin goal should be moved to KubernetesHelmTask

AC
@manusa manusa added the component/gradle-plugin Related to the Gradle Plugins label Oct 20, 2021
This was referenced Oct 20, 2021
Open
Closed
@rohanKanojia rohanKanojia self-assigned this Oct 25, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 26, 2021
@rohanKanojia
Fix eclipse-jkube#1052: Add k8sHelm task to Kubernetes Gradle Plugin
a96e3c4 
Add `k8s:helm` maven equivalent `k8sHelm` task to Kubernetes Gradle
Plugin.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 26, 2021
@rohanKanojia
Fix eclipse-jkube#1052: Add k8sHelm task to Kubernetes Gradle Plugin
3810234 
Add `k8s:helm` maven equivalent `k8sHelm` task to Kubernetes Gradle
Plugin.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 26, 2021
@rohanKanojia
Fix eclipse-jkube#1052: Add k8sHelm task to Kubernetes Gradle Plugin
16d9750 
Add `k8s:helm` maven equivalent `k8sHelm` task to Kubernetes Gradle
Plugin.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Oct 26, 2021
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 26, 2021
@rohanKanojia
Fix eclipse-jkube#1052: Add k8sHelm task to Kubernetes Gradle Plugin
4d0f3a5 
Add `k8s:helm` maven equivalent `k8sHelm` task to Kubernetes Gradle
Plugin.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Oct 27, 2021
@rohanKanojia @manusa
Fix #1052: Add k8sHelm task to Kubernetes Gradle Plugin
78ca19d 
Add `k8s:helm` maven equivalent `k8sHelm` task to Kubernetes Gradle
Plugin.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa reopened this Oct 27, 2021
@rohanKanojia
Copy link
Member

Have you reopened this for implementing integration test?

@manusa
Copy link
Member Author

manusa commented Oct 27, 2021

We need to implement the integration test too (not included in AC).
But there is an actual point from the AC missing.

@rohanKanojia
Copy link
Member

rohanKanojia commented Oct 27, 2021 •
edited
Loading

Shall I create the issue? Or are you planning to create it?

Edit: let me create it instead

@rohanKanojia rohanKanojia mentioned this issue Oct 27, 2021
Open
@rohanKanojia
Copy link
Member

I've created #1073 for future reference.

@manusa manusa closed this as completed Oct 27, 2021
@manusa manusa added this to the 1.5.0 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/gradle-plugin Related to the Gradle Plugins
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Fix #1052: Add k8sHelm task to Kubernetes Gradle Plugin rohanKanojia/jkube
2 participants
@manusa @rohanKanojia