You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can simplify this to use jkubeProject.getArtifact() directly. But this doesn't work very well with maven. In case of maven, the value present in mavenProject.getArtifact().getFile() depends on the maven phase the goal was executed. Take this example:
We need to find a way to smartly handle all these scenarios so that JKubeProject gets initialized with correct artifact file in MavenUtil.convertMavenProjectToJKubeProject. Right now we're managing with just a workaround which checks for artifact when manual inferring doesn't return correct artifact.
The text was updated successfully, but these errors were encountered:
Description
Info
Right now in JKubeProjectUtil.getFinalOutputArtifact() method we're trying to infer final output artifact(final jar) in a bit hacky-ish way:
https://github.com/eclipse/jkube/blob/cff79a222dcf8909ddd124f37437c9acee46721a/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/JKubeProjectUtil.java#L118-L129
We can simplify this to use
jkubeProject.getArtifact()
directly. But this doesn't work very well with maven. In case of maven, the value present inmavenProject.getArtifact().getFile()
depends on the maven phase the goal was executed. Take this example:We need to find a way to smartly handle all these scenarios so that JKubeProject gets initialized with correct artifact file in MavenUtil.convertMavenProjectToJKubeProject. Right now we're managing with just a workaround which checks for artifact when manual inferring doesn't return correct artifact.
The text was updated successfully, but these errors were encountered: