Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesResourceTask: implement Merge With Dekorate functionality #836

Open
2 tasks
manusa opened this issue Aug 9, 2021 · 1 comment
Open
2 tasks

KubernetesResourceTask: implement Merge With Dekorate functionality #836

manusa opened this issue Aug 9, 2021 · 1 comment
Assignees
@rohanKanojia
Labels
component/gradle-plugin Related to the Gradle Plugins

Comments

@manusa
Copy link
Member

manusa commented Aug 9, 2021

Description

Child of #31
Blocked by #835

AC

  • Implement merge with Dekorate functionality
  • Port spring-boot-dekorate Maven example
@manusa manusa mentioned this issue Aug 9, 2021
Open
16 tasks
@manusa manusa added component/gradle-plugin Related to the Gradle Plugins enhancement New feature or request and removed enhancement New feature or request labels Aug 9, 2021
@manusa manusa changed the title KubernetesResourceTask implement Merge With Dekorate functionality KubernetesResourceTask: implement Merge With Dekorate functionality Aug 12, 2021
@manusa manusa mentioned this issue Sep 10, 2021
Open
@rohanKanojia rohanKanojia self-assigned this Nov 10, 2021
@rohanKanojia
Copy link
Member

Code for handling Dekorate detection already seems to be there:

https://github.com/eclipse/jkube/blob/2a328258896d2079a3f3d8059c40b7cb141099da/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/KubernetesResourceTask.java#L73-L80

I think we just need to add a quickstart and check if Dekorate integration is working okay

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 11, 2021
@rohanKanojia
Fix eclipse-jkube#836: Port Spring Boot Dekorate Quickstart to Gradle
acc30a0 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/gradle-plugin Related to the Gradle Plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manusa @rohanKanojia