You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was writing some tests related to System properties in #957 where SystemMock could be used for mocking System properties. Unfortunately, it's based on JMockit(as the rest of JKube Kit) and the Gradle Plugin module is based on Mockito.
We plan to Migrate JKube tests to Mockito in the future #857
Whenever we're able to merge Gradle module to main branch and migrate to Mockito. GradleUtilTest tests
which are using System.setProperty and then System.clearProperty should be updated to use SystemMock instead.
The text was updated successfully, but these errors were encountered:
rohanKanojia
changed the title
Refactor SystemMock utility in commin-test to use mockito
Refactor SystemMock utility in commin-test to use mockito and use in GradleUtilTest to mock System properties
Sep 30, 2021
manusa
changed the title
Refactor SystemMock utility in commin-test to use mockito and use in GradleUtilTest to mock System properties
Refactor SystemMock utility in common-test to use mockito and use in GradleUtilTest to mock System properties
Nov 8, 2021
I'd vote for our own extension. It won't be hard to implement and won't require additional dependencies.
Something as simple as an annotation to set a system property and an extension that would backup its original value and restore it for each test execution would be quite simple to implement.
Maybe in the scope of #857
Description
Blocked on #957 #857 #31
I was writing some tests related to System properties in #957 where SystemMock could be used for mocking System properties. Unfortunately, it's based on JMockit(as the rest of JKube Kit) and the Gradle Plugin module is based on Mockito.
We plan to Migrate JKube tests to Mockito in the future #857
Whenever we're able to merge Gradle module to main branch and migrate to Mockito. GradleUtilTest tests
which are using
System.setProperty
and thenSystem.clearProperty
should be updated to use SystemMock instead.The text was updated successfully, but these errors were encountered: