Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and Test with GitHub Actions on Windows and Mac OS #1080

Closed
kwin opened this issue Nov 22, 2022 · 8 comments · Fixed by #1081 or #1154
Closed

Build and Test with GitHub Actions on Windows and Mac OS #1080

kwin opened this issue Nov 22, 2022 · 8 comments · Fixed by #1081 or #1154

Comments

@kwin
Copy link
Member

kwin commented Nov 22, 2022

Currently some tests fail on those OS which makes the life for contributors using one of those OS really hard.

This is related to #1046.

@kwin kwin mentioned this issue Nov 23, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Nov 23, 2022
@HannesWell
Copy link
Contributor

HannesWell commented Nov 23, 2022

Enabling a GH workflow to run on Windows should not be a problem.

My concern about also running verification builds on Mac is that Mac-Runners are ten times more expensive with regards to our CI minutes and Windows is already twice as expensive as Linux:
https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#minute-multipliers

I'm not sure if we have the usual 2000min per month or if the EFN made a good deal with GH so that we have more. But if we only have 2000min per Month and assume we would build on Linux, Windows and Mac and the build takes about ~15min, each run costs us (1+2+10) *15min = 195min, so we have only about ~10 builds per month for master and PR builds.

@laeubi for Tycho the build pipeline takes much longer and I assume we exceed the default 2000mins per month there. Did you know if anyone bought more minutes? Or do we just get more?

The minute prices of there runners are here:
https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners
A 15min build on MacOS would cost 1.20$.

@HannesWell
Copy link
Contributor

And of course the Mac build would have to work first, but I cannot ensure that.

@HannesWell
Copy link
Contributor

HannesWell commented Nov 23, 2022

As an alternative it would be possible to have a self-hosted Mac-runner:
https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners

Either one provides one or we could ask the Eclipse-Infra team for one.

@laeubi
Copy link
Member

laeubi commented Nov 23, 2022

SWT uses mac runners as well and I have not yet seen any restrictions here and I'm quite sure no one pays for it...

@laeubi
Copy link
Member

laeubi commented Nov 23, 2022

I think this is more applicable:
https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories

GitHub plan Total concurrent jobs Maximum concurrent macOS jobs
Free 20 5

HannesWell added a commit to HannesWell/m2e-core that referenced this issue Nov 23, 2022
@HannesWell
Copy link
Contributor

I think this is more applicable: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories

Reading that I think I understand it wrong all the time. Thanks for that hint.
Looks like the limit of free minutes only applies to private repos in free accounts.

For private repositories, each GitHub account receives a certain amount of free minutes and storage for use with GitHub-hosted runners, depending on the product used with the account

Then there is no reason to not build+test on macOS as well. It can't be slower than Windows...
I updated the PR. @kwin then it would be your turn to fix the failing tests. :)

HannesWell added a commit to HannesWell/m2e-core that referenced this issue Nov 23, 2022
@HannesWell
Copy link
Contributor

@kwin can you please try to debug the test-failures on macOS?
With the latest M2E you can put a break-point at the failing test code and just have to add the property
debugPort e.g. with value 8000 to the m2e-core--build launch config and RUN it. Then the build should stop the test execution at your break-point.

Btw. are you sure your clean-up in #1079 did not break the tests?

HannesWell added a commit to HannesWell/m2e-core that referenced this issue Nov 28, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 3, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 4, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 8, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 15, 2022
kwin added a commit to kwin/m2e-core that referenced this issue Dec 22, 2022
kwin added a commit to kwin/m2e-core that referenced this issue Dec 22, 2022
HannesWell pushed a commit to kwin/m2e-core that referenced this issue Dec 22, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 22, 2022
kwin added a commit to kwin/m2e-core that referenced this issue Dec 22, 2022
HannesWell pushed a commit to HannesWell/m2e-core that referenced this issue Dec 22, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 22, 2022
HannesWell pushed a commit to kwin/m2e-core that referenced this issue Dec 28, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 28, 2022
kwin added a commit to kwin/m2e-core that referenced this issue Dec 29, 2022
Fix several race conditions

This closes eclipse-m2e#1046
This closes eclipse-m2e#1080
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 29, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 31, 2022
HannesWell added a commit that referenced this issue Dec 31, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 31, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Dec 31, 2022
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Jan 2, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Feb 15, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Mar 6, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Mar 18, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Mar 20, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Mar 29, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Jun 16, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Aug 22, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Oct 5, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Nov 14, 2023
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Feb 20, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Feb 20, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Mar 17, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Aug 24, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Aug 25, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Aug 26, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Aug 26, 2024
HannesWell added a commit to HannesWell/m2e-core that referenced this issue Aug 27, 2024
HannesWell added a commit that referenced this issue Aug 27, 2024
@HannesWell
Copy link
Contributor

M2E is now also built and tested on Windows as of #1163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants