-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: "Jump in" table second row lacks contrast #33
Comments
@wimjongman : Do you know where we can find a dark mode version of the used svg images (https://github.com/primer/octicons) |
@Chealer Thanks for reporting! Are you able to provide a patch for the issues you mentioned? |
My "pleasure" @wimjongman |
Thanks @Chealer! Yes, the icons can be replaced, and the repository icon is weird. If you have a suitable replacement icon, you can put it in the patch. I also just recently started porting the old wiki to the GitHub wiki. While you are at it, you could add a section in this table for the wiki. https://github.com/eclipse-mylyn/org.eclipse.mylyn/wiki |
The README's Jump in section contains a table with 2 rows. The second row of that table looks empty, unless one looks closely or uses a traditional color scheme (black text on a white background). Each cell only contains one black (monochrome) image which―in dark mode―has almost no contrast with the almost black background, as "can be seen" in the following screenshot:
Either the background's color should be set, or the image should not be monochrome.
By the way
The text was updated successfully, but these errors were encountered: