Error validating SDK launch due missing JRE 1.1 support

[iloveeclipse]

After removing support for JRE 1.1 (eclipse-equinox/equinox#572 & eclipse-jdt/eclipse.jdt.debug#424) there is a validation error shown on startup of SDK from SDK.

PDE should update it's logic to validate launches.

[akurtakov]

@merks As this one comes from Orbit I would say that the fix should be there, no?

[iloveeclipse]

PDE allows to use any libraries in the platform, and PDE can be used to debug older platforms.
So the fix must be in PDE / SDK.

[merks]

There's nothing wrong with such a requirement. Even the latest Java 21 provides those system capabilities:

So if PDE says those capabilities are missing, it's not looking at the right thing or not looking in the right way.

[akurtakov]

Acked about capability being provided and thus PDE fix is due.
eclipse-equinox/equinox#571 (comment) makes me believe that we should try to not ship bundles with "non-standard" EEs too.

[merks]

FYI, for history, you can see this issue:

eclipse-orbit/orbit#52

This legacy bundle is a drop-in replacement for this:

https://repo1.maven.org/maven2/xml-apis/xml-apis-ext/1.3.04/

That thing provides no source. If it did, I would have just wrapped in with m2e/tycho BND support which would produce this manifest:

So standard or not, BND produces that and org.eclipse.osgi.storage.Storage.calculateEECapabilities(Version) computes that, so I tried to reproduce something that includes actual sources and that follows that same expect result.

[HannesWell]

PDE allows to use any libraries in the platform, and PDE can be used to debug older platforms. So the fix must be in PDE / SDK.

Yes. After all I think it is simpler to just revert the removal in Equinox instead of cleaning up everthing from JRE-1.1. There are some left-overs of it in Equinox (e.g. what Ed mentioned) and also in PDE etc.
Created eclipse-equinox/equinox#596 to revert it and add the system-packages currently hard-coded in PDE.
To fully fix this issue eclipse-jdt/eclipse.jdt.debug#425 has to be reverted because PDE relies on the EE JDT provides. So at least the JRE-1.1 EE must be restored in JDT.

Once eclipse-equinox/equinox#596 is submitted the following hard-coded list can be removed from PDE:

eclipse.pde/build/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/site/PDEState.java

Lines 580 to 603 in 860100e

	"JRE-1.1", List.of("java.applet", //
	"java.awt", //
	"java.awt.datatransfer", //
	"java.awt.event", //
	"java.awt.image", //
	"java.awt.peer", //
	"java.beans", //
	"java.io", //
	"java.lang", //
	"java.lang.reflect", //
	"java.math", //
	"java.net", //
	"java.rmi", //
	"java.rmi.dgc", //
	"java.rmi.registry", //
	"java.rmi.server", //
	"java.security", //
	"java.security.acl", //
	"java.security.interfaces", //
	"java.sql", //
	"java.text", //
	"java.text.resources", //
	"java.util", //
	"java.util.zip"),

[iloveeclipse]

Once eclipse-equinox/equinox#596 is submitted the following hard-coded list can be removed from PDE

@HannesWell : do you plan to provide a PR for that?

[HannesWell]

Once eclipse-equinox/equinox#596 is submitted the following hard-coded list can be removed from PDE

@HannesWell : do you plan to provide a PR for that?

See #1239.

With eclipse-jdt/eclipse.jdt.debug#431 being merged I think this is resolved.
Thank you @iloveeclipse for providing the PR for JDT.