Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1308: Fix E4 editor boolean parameters #1465

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stewedbeef
Copy link

No description provided.

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
features/org.eclipse.e4.core.tools.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 602ab529a52587990466b13388c6d04dd65dc399 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sat, 9 Nov 2024 06:18:03 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
index e93a68e6c9..8c540a8dd6 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.e4.tools.emf.ui;singleton:=true
-Bundle-Version: 4.8.500.qualifier
+Bundle-Version: 4.8.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17
diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
index 914221efff..8484d0cbec 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
@@ -21,7 +21,7 @@
 
   <groupId>eclipse.platform.ui</groupId>
   <artifactId>org.eclipse.e4.tools.emf.ui</artifactId>
-  <version>4.8.500-SNAPSHOT</version>
+  <version>4.8.600-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
diff --git a/features/org.eclipse.e4.core.tools.feature/feature.xml b/features/org.eclipse.e4.core.tools.feature/feature.xml
index 5f9b6df946..fe474fda39 100644
--- a/features/org.eclipse.e4.core.tools.feature/feature.xml
+++ b/features/org.eclipse.e4.core.tools.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.e4.core.tools.feature"
       label="%featureName"
-      version="4.30.300.qualifier"
+      version="4.30.400.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@HannesWell
Copy link
Member

HannesWell commented Nov 14, 2024

Thank you for this PR aiming to resolve #1308.

Could you be so kind and provide an example to verify this change?

Furthermore please squash all your commits into one with a meaningful message that covers the change as whole and force push it to the branch of this PR.
If you want to record your team members in the commit you can add them as co-authors to the commit message using the format:
Co-authored-by: name <name@example.com>

But your co-authors also have to sign the Eclipse ECA: https://www.eclipse.org/legal/eca/faq/

Copy link

Test Results

   285 files  ±0     285 suites  ±0   48m 24s ⏱️ - 5m 27s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 41bcb34. ± Comparison against base commit ee1f4a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants