[scr 1.4] constructor for injection must be public #1218 Pull Request #1474
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor is annotated with @activate.
…otations/messages.properties
|
Hi @EverettHanke thanks for this update. First please squash all your commits into one with a meaningful message that covers the change as whole and force push it to the branch of this PR. Please don't create a new PR, you can simply update its change by using git force-push! Furthermore please revert all brace re-formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #1218 solution.
Gives a warning when a constructor is injectable but is not public/annotated with @activiate telling users to make constructor public.