Test failure in I-build #55
Comments
|
This looks closely related to recent changes to osgi.utils. |
* Stop using assertThat(message, variable equalTo(constant). It's just complicated way to write assertEquals(message, constant, variable) which even calls out to yet another library. * Remove needless throws declaration. Seen while investigating eclipse-pde#55 Change-Id: If4b7a6937a9ec9acac88e435c21c52f7e7e6f1d8
* Stop using assertThat(message, variable equalTo(constant). It's just complicated way to write assertEquals(message, constant, variable) which even calls out to yet another library. * Remove needless throws declaration. Seen while investigating #55 Change-Id: If4b7a6937a9ec9acac88e435c21c52f7e7e6f1d8
Yes. From a quick first look it looks like the replacing bundles are not included into the launch config. I will have a look at this this evening. |
If templates are not using "include required Plug-ins automatically" please adjust them to do so. We should do as much as possible to make people know of new automation and it being on by default for new projects. |
With the latest changes in Equinox o.e.osgi.util was replaced by the corresponding 'original' OSGi-reference bundles that are required+reexported by o.e.osgi.util. Unfortunately the re-export does not help in this product launch. Therefore o.e.osgi.util is replaced by the actually needed plugins. And apply one minor code improvement in TestPDETemplates Fixes eclipse-pde#55
With the latest changes in Equinox o.e.osgi.util was replaced by the corresponding 'original' OSGi-reference bundles that are required+reexported by o.e.osgi.util. Unfortunately the re-export does not help in this product launch. Therefore o.e.osgi.util is replaced by the actually needed plug-ins. And apply one minor code improvement in TestPDETemplates. Fixes eclipse-pde#55
|
For the record, as Aleks suspected this was was a side effect of by eclipse-equinox/equinox.framework#41
Unfortunately we cannot use that yet because that only works on Launch-Config level. For product level this is almost completed in PR #7, but then the automatic inclusion of requirements can only be controlled in the IDE, not yet in a Tycho/Maven build (not sure if this is relevant for the template). Nevertheless this template can really benefit from mixed-products for which I'm planning to add support to PDE soon (P2/Tycho already supports it for a while). I have already created a draft in PR #61 how it should look then. |
With the latest changes in Equinox o.e.osgi.util was replaced by the corresponding 'original' OSGi-reference bundles that are required+reexported by o.e.osgi.util. Unfortunately the re-export does not help in this product launch. Therefore o.e.osgi.util is replaced by the actually needed plug-ins. Fixes eclipse-pde#55
With the latest changes in Equinox o.e.osgi.util was replaced by the corresponding 'original' OSGi-reference bundles that are required+reexported by o.e.osgi.util. Unfortunately the re-export does not help in this product launch. Therefore o.e.osgi.util is replaced by the actually needed plug-ins. And apply one minor code improvement in TestPDETemplates. Fixes eclipse-pde#55
With the latest changes in Equinox o.e.osgi.util was replaced by the corresponding 'original' OSGi-reference bundles that are required+reexported by o.e.osgi.util. Unfortunately the re-export does not help in this product launch. Therefore o.e.osgi.util is replaced by the actually needed plug-ins. And apply one minor code improvement in TestPDETemplates. Fixes #55
In the last few I-builds we have test failure:
https://download.eclipse.org/eclipse/downloads/drops4/I20220428-1800/testresults/html/org.eclipse.pde.ui.templates.tests_ep424I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html
The text was updated successfully, but these errors were encountered: