Execution of workbench closing / session tests

[HeikoKlare]

When adding a test for #1086 that needs to close the workbench, I found two kinds of tests that close/restart a new workbench, which are those executed as SessionTest in the org.eclipse.ui.tests bundle or those executed as ordinary tests with each starting its own workbench in the org.eclipse.ui.tests.rcp bundle. Now all these tests do not seem to be executed in any CI environment (neither GitHub actions nor in Jenkins builds).

The session tests are disabled in Maven build used for GH actions due to only executing one test suite that does not include them

eclipse.platform.ui/tests/org.eclipse.ui.tests/build.properties

Line 32 in 9739280

pom.model.property.testClass = org.eclipse.ui.tests.UiTestSuite

and in Jenkins integration build due to

eclipse.platform.ui/tests/org.eclipse.ui.tests/test.xml

Lines 69 to 74 in 9739280

	<!--ant target="ui-test" antfile="${library-file}" dir="${eclipse-home}">
	<property name="data-dir" value="${session-data-folder}"/>
	<property name="plugin-name" value="${plugin-name}"/>
	<property name="classname"
	value="org.eclipse.ui.tests.session.SessionTests"/>
	</ant-->

The RCP tests are disabled in Maven build used for GH actions due to tests being skipped completely

eclipse.platform.ui/tests/org.eclipse.ui.tests.rcp/build.properties

Line 30 in 9739280

pom.model.property.skipTests = true

and the bundle not being considered in Jenkins integration builds (at least I cannot find any logs for it, e.g., here).

Does anyone know whether...

1. these tests are only not executed in automated builds for technical reasons and would be worth some effort to be enabled there?
2. there are other kinds of tests that allow to test the closing behavior of a workbench with which a new test could/should be aligned?

Thanks in advance!

[iloveeclipse]

See a5dc9ce / https://bugs.eclipse.org/bugs/show_bug.cgi?id=398869. The tests were disabled during transition to e4 (because lot of things were broken I guess), and like with many other bad things happened during this transition, they were not enabled anymore.

[HeikoKlare]

Thanks for that information!
At least, it seems to be possible to easily fix and reenable the RCP test project, see #1145. I will provide the reactivation of those tests as proper PRs to ensure that we have some testing for behavior of workbench sessions (including startup/shutdown) again.