-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some way to pin a Debug Inspect window #1905
Comments
@mickaelistria can you share a screenshot / cast? I can hardly follow the description mostly as I seldom use your described workflow. |
You can use the Expressions View instead of Inspect. |
that doesn't work with "2 distinct executions" (which is the most important part of the workflow), as switching to another StackFrame updates the values. I basically want a way to be able to see some values from 2 distinct stack frames, without having to have 2 distinct workbench windows. |
If it is 2 different debugees you could use 2 distinct workspaces. |
When in desperate need, I use 2 workbench windows (Window > New Window) which can allow to have different stackframes selected in each window and update all the context. It's really powerful, but it's not so easy to use and it often seems overkill to quickly compare 2 values. A first idea would be to augment the Inspect popop with 2 new actions (Pin/Close) in its action menu: So it would look like
|
But how could the user know which Window belongs to which frame? |
in a 1st iteration, I think it could be up to them to remember, as it's not (yet?) a very common workflow,. |
Things that need later to be done are a blocker for me, as otherwise they are usually not done. |
It seems like we could implement it in PopupDialog, so it could also help some other stories. |
I doubt having N pinned dialogs is "the" solution here. I personally never use this functionality, but if I would use it in the way you do, I would probably just want to "move" current popup content to Expressions view and there provide a way to "pin" expressions to threads/frames, as long as they run/exist. |
I think it's more or less what I suggested in eclipse-platform/eclipse.platform#531 |
Probally I can't understand the use case, but you proposeda "diff" view and here you want persistent per frame inspection values? |
No, in the other issue, I propose that we can show values from multiple sources in the Variable/Expressions view (I'm against yet-another-view), adding them as colums.
Yes, I just want to be able to look at 2 inspected expressions, from whichever source, simultaneously. And this is currently only possible without 2 distinct workbench window. |
I've managed to add the menu entries and so on, but pinning seems more deeply rooted than I thought. Here is the stack that shows the dialog closing when an external event happens. I was hoping for some listener to tweak in PopupDialog, but it seems deeper
|
My bad, please ignore last comment which was exactly about ESCAPE being pressed. Everything seems fine, I'm pushing a pull request. |
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
PR is #1906 |
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
And eclipse-platform/eclipse.platform#1403 as consumer |
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes eclipse-platform#1905
In some circumstances (eg comparisons), users may want PopopDialogs to remain visible when switching attention to another area. This introduces an opt-in flag to present a "Pin dialog" menu (and a "Close") to allow the dialog to stick when users selects it. Fixes #1905
Let's make sure issue is not already fixed in latest builds first.
Suggestion
I want to compare some inspected (select in code then right-lick > Inspect) value in 2 distinct executions I'm debugging.
Currently, whenever I click out of the 1st inspect window to try to open a second one (which involves switching target in the debug view, going to the other file, selecting the expression then right-click > Evaluate), the 1st inspect window gets closed and I cannot efficiently compare.
It would be extremely convenient to have an option on the Inspect window to "pin" it so that it doesn't close on focus out, and it just closes when users wants to close it.
Community
The text was updated successfully, but these errors were encountered: