Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify formatting by reinitiating Black #85

Open
manzanillo opened this issue Oct 10, 2024 · 2 comments
Open

Unify formatting by reinitiating Black #85

manzanillo opened this issue Oct 10, 2024 · 2 comments

Comments

@manzanillo
Copy link
Contributor

When working with the code I experienced a lot of different conventions being used when it comes to string indications ("" vs ''), spaces (e.g. def func1(param = "abc") vs def func1(param="abc")). In order to avoid to create too much noise in PR for new contributors putting Black (and maybe isort) back into use could be very helpful.

@positr0nium
Copy link
Contributor

@bastibock what do you think about this?

@bastibock
Copy link
Contributor

I agree! This definitely makes sense. We tried integrating it before but had some issues, especially when integrating into the GitLab CI/CD pipeline. But since the repo is on GitHub now, we should integrate it here.
I will start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants