refactor: improve type casting and validation in _get_normalized function

Author: Arnaud Riess

src/extensions/score_metamodel/checks/check_options.py

@@ -11,6 +11,7 @@
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
 import re
+from typing import cast
 
 from score_metamodel import (
     CheckLogger,
@@ -40,8 +41,13 @@ def _get_normalized(need: NeedItem, key: str, remove_prefix: bool = False) -> li
         if remove_prefix:
             return [_remove_namespace_prefix_(raw_value)]
         return [raw_value]
-    if isinstance(raw_value, list) and all(isinstance(v, str) for v in raw_value):
-        str_list: list[str] = raw_value
+    if isinstance(raw_value, list):
+        # Verify all elements are strings
+        raw_list = cast(list[object], raw_value)
+        for item in raw_list:
+            if not isinstance(item, str):
+                raise ValueError
+        str_list = cast(list[str], raw_value)
         if remove_prefix:
             return [_remove_namespace_prefix_(v) for v in str_list]
         return str_list