Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Details view does not react when its input is deselected #4312

Closed
pcdavid opened this issue Dec 13, 2024 · 1 comment · Fixed by #4314 or #4321
Closed

The Details view does not react when its input is deselected #4312

pcdavid opened this issue Dec 13, 2024 · 1 comment · Fixed by #4314 or #4321

Comments

@pcdavid
Copy link
Member

pcdavid commented Dec 13, 2024

Steps to reproduce

  1. Open a project. Initially there is no element selected, and the Details view correctly says so: "No object selected".
  2. Select an element in the Explorer view.
  3. Its details are shown in the Details view, and the onboard area is updated too depending on the selected element's type.
  4. Deselect the element in the Explorer (Ctrl-click).
  5. Now the workbench selection is empty as it was in step 1. The onboard area is updated, but the Details view continues to show the details of the previously selected element. It should be back to the "No object selected" state.
Capture.video.du.2024-12-13.15-06-31.mp4
@pcdavid
Copy link
Member Author

pcdavid commented Dec 13, 2024

Note that in such a state the Details view is half-functional: it can send mutations when the user interacts with the widgets but will not receive the new values:

Capture.video.du.2024-12-13.17-31-28.mp4

Worse, if the displayed element is deleted by another user, the form stays visible but this time interactions with it completely fail.

pcdavid added a commit that referenced this issue Dec 13, 2024
Bug: #4312
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Dec 13, 2024 that will close this issue
39 tasks
@sbegaudeau sbegaudeau added this to the 2025.1.0 milestone Dec 16, 2024
sbegaudeau pushed a commit that referenced this issue Dec 16, 2024
Bug: #4312
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Dec 17, 2024 that will close this issue
39 tasks
pcdavid added a commit that referenced this issue Dec 17, 2024
Bug: #4312
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 18, 2024
Bug: #4312
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 19, 2024
Bug: #4312
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 19, 2024
Bug: #4312
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment