Skip to content

fix: issues in New Frontend #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

duonglq-tsdv
Copy link
Contributor

@duonglq-tsdv duonglq-tsdv commented Dec 10, 2024

Pull Request Description

What does this PR do?

  1. [Delete Project] Enabled the Delete button.
  2. [Project List] Fixed the behaviors of the Clearing Request icon.
  3. [Edit & View Release] Corrected data in "License Scan Report Result," "Legal Evaluation," and "License Agreement" fields
  4. [Request] Prevent application from signing out when visiting the Request page

Pre-condition:

  • The user is logged in.

How to Test?

1. [Delete Project] Enabled the Delete button.

Pre-condition:

  • There is at least one existing project.

Procedure:

  • Option 1: On the Project list page, click the delete button in the Action column to delete a project.
  • Option 2: On the Update Project page, click the "Delete Project" button.

Expected:

  • A "Delete Project" dialog appears with the message "Do you really want to delete the project?"
  • The project is successfully deleted after clicking the "Delete Project" button.

Note:

  • The comment field in the Delete Project dialog is currently non-functional as the moderation request feature is still in development.

image

2. [Project List] Fixed the behaviors of the Clearing Request icon.

Pre-condition:

  • There is at least one existing project.

Procedure:

  • No Clearing Request: If a project has no Clearing Request, click "Create Clearing Request" in the Actions column. The Clearing Request dialog should open.
  • Existing Clearing Request: If a Clearing Request exists (icon displayed in orange), click "View Clearing Request" to open the View Clearing Request dialog.

Expected:

  • The Clearing Request dialog opens for creating a new Clearing Request.
  • The View Clearing Request dialog opens, displaying all relevant Clearing Request information.

image
image


3. [Edit & View Release] Corrected data in "License Scan Report Result," "Legal Evaluation," and "License Agreement" fields

Pre-condition:

  • There is at least one existing component and its release is created.

Procedure:

  • Navigate to the Component/Release/Clearing Details tab and update the fields:
    + "License Scan Report Result"
    + "Legal Evaluation"
    + "License Agreement"
  • Click the "Update Release" button.

Expected:

  • The updated data is correctly displayed in the View Release/Clearing Details tab.

image
image


4. [Request] Prevent application from signing out when visiting the Request page

Procedure:

  • Navigate to Request tab.

Expected:

  • The user can access the Request page and its four sub tabs (Open and Closed Moderation Requests, Open and Closed Clearing Request)

Note:

  • Errors in the Open Clearing Request tab related to data fetching likely due to this feature currently in development. This fix addresses only the sign-out issue.

image

@duonglq-tsdv duonglq-tsdv force-pushed the fix/bug-new-frontend branch 2 times, most recently from 8077c98 to 9f26f13 Compare December 10, 2024 09:34
@duonglq-tsdv duonglq-tsdv changed the title Fix/bug new frontend fix: issues in New Frontend Dec 10, 2024
@duonglq-tsdv duonglq-tsdv marked this pull request as ready for review December 10, 2024 10:01
@duonglq-tsdv duonglq-tsdv marked this pull request as draft December 10, 2024 10:08
@duonglq-tsdv duonglq-tsdv force-pushed the fix/bug-new-frontend branch 5 times, most recently from bea61ad to a0b2581 Compare December 13, 2024 03:24
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@heliocastro heliocastro self-requested a review December 15, 2024 14:34
@heliocastro
Copy link
Contributor

@duonglq-tsdv Besides i appreciate the fixes, would be more sensible if you do one pull request for fixes.
Trying to fix several things in one shot make it harder to track changes, correct or not.
So, even if is a one liner fix ( marked as a chore ), it will be ok as a single PR

@duonglq-tsdv duonglq-tsdv marked this pull request as ready for review December 16, 2024 04:34
@duonglq-tsdv
Copy link
Contributor Author

@duonglq-tsdv Besides i appreciate the fixes, would be more sensible if you do one pull request for fixes. Trying to fix several things in one shot make it harder to track changes, correct or not. So, even if is a one liner fix ( marked as a chore ), it will be ok as a single PR

Thank you for the feedback! I’ll make sure to follow this in the future, even for minor changes.

@hoangnt2 hoangnt2 removed the WIP label Dec 17, 2024
Copy link
Contributor

@hoangnt2 hoangnt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@heliocastro heliocastro merged commit c1eb48b into eclipse-sw360:main Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants