Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Node 14 #43

Closed
AxelRICHARD opened this issue Jan 20, 2021 · 6 comments
Closed

Compatibility with Node 14 #43

AxelRICHARD opened this issue Jan 20, 2021 · 6 comments

Comments

@AxelRICHARD
Copy link

Hello, I am trying to build Theia with the current LTS version of Node.js - 14.15.4, but the problem seems that dugite-extra is not compatible with Node 13+.

Do you plan to be compatible with Node 14?

Best regards,

@duncdrum
Copy link

even more problematic electron-builder requires node 14+

see evolvedbinary/fusion-studio#91

This was referenced Jul 30, 2021
ccheraa referenced this issue in ccheraa/fusion-studio Aug 20, 2021
@vince-fugnitto
Copy link
Member

@msujew @thegecko do you know if there are any plans to maintain and uplift dugite-extra? As far as I understand it is only used for applications which consume @theia/git (which I believe is true for both your cases), and it might be good to uplift as to support newer versions of theia.

@thegecko
Copy link
Member

thegecko commented Nov 2, 2021

No plans from us at the moment, but may be sensible to look into.

cc @mcgordonite

@msujew
Copy link
Member

msujew commented Nov 2, 2021

@vince-fugnitto Yes, we should definitely uplift the dependency (for the time being). I've seen ideas of deprecating @theia/git in favor of the appropriate vscode extensions in the future. What's the plan on that?

@vince-fugnitto
Copy link
Member

@vince-fugnitto Yes, we should definitely uplift the dependency (for the time being). I've seen ideas of deprecating @theia/git in favor of the appropriate vscode extensions in the future. What's the plan on that?

@msujew that is what we are currently doing, it allows us to use git-related extensions such as gitlens. As for removing it as part of the framework (or deprecating it) there is the following issue eclipse-theia/theia#7482. I believe Arm was planning on moving functionality they required out of it: eclipse-theia/theia#7152.

@msujew
Copy link
Member

msujew commented Feb 8, 2022

I've updated dugite-extra to 0.1.15 removing the node constraint. I'll close this.

@msujew msujew closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants