From 4598a8861a4f41f8daecaf5ced6293043ea5733a Mon Sep 17 00:00:00 2001 From: Phil Schneider Date: Thu, 24 Oct 2024 13:37:04 +0200 Subject: [PATCH] fix: adjust query for technical user creation (#1113) Refs: #1112 Reviewed-By: Evelyn Gurschler --- .../BusinessLogic/ServiceAccountBusinessLogic.cs | 1 + .../Repositories/ProcessStepRepository.cs | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/administration/Administration.Service/BusinessLogic/ServiceAccountBusinessLogic.cs b/src/administration/Administration.Service/BusinessLogic/ServiceAccountBusinessLogic.cs index 4f97cf996d..2e04568eec 100644 --- a/src/administration/Administration.Service/BusinessLogic/ServiceAccountBusinessLogic.cs +++ b/src/administration/Administration.Service/BusinessLogic/ServiceAccountBusinessLogic.cs @@ -353,6 +353,7 @@ public async Task HandleServiceAccountCreationCallback(Guid processId, Authentic { throw new ConflictException($"ServiceAccountId must be set for process {processId}"); } + if (processData.ServiceAccountVersion is null) { throw new UnexpectedConditionException("ServiceAccountVersion or IdentityVersion should never be null here"); diff --git a/src/portalbackend/PortalBackend.DBAccess/Repositories/ProcessStepRepository.cs b/src/portalbackend/PortalBackend.DBAccess/Repositories/ProcessStepRepository.cs index 06f81f2714..564d307ede 100644 --- a/src/portalbackend/PortalBackend.DBAccess/Repositories/ProcessStepRepository.cs +++ b/src/portalbackend/PortalBackend.DBAccess/Repositories/ProcessStepRepository.cs @@ -110,6 +110,7 @@ public IAsyncEnumerable GetActiveProcesses(IEnumerable p public Task<(ProcessTypeId ProcessTypeId, VerifyProcessData ProcessData, Guid? ServiceAccountId, Guid? ServiceAccountVersion)> GetProcessDataForServiceAccountCallback(Guid processId, IEnumerable processStepTypeIds) => dbContext.Processes + .AsNoTracking() .Where(x => x.Id == processId) .Select(x => new ValueTuple( x.ProcessTypeId, @@ -126,6 +127,7 @@ public IAsyncEnumerable GetActiveProcesses(IEnumerable p public Task<(ProcessTypeId ProcessTypeId, VerifyProcessData ProcessData, Guid? ServiceAccountId)> GetProcessDataForServiceAccountDeletionCallback(Guid processId, IEnumerable? processStepTypeIds) => dbContext.Processes + .AsNoTracking() .Where(x => x.Id == processId && x.ProcessTypeId == ProcessTypeId.DIM_TECHNICAL_USER) .Select(x => new ValueTuple( x.ProcessTypeId,