Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Vert.x Open API 'multipleOf' validation #106

Open
boethomas-corp opened this issue Apr 25, 2023 · 1 comment
Open

Incorrect Vert.x Open API 'multipleOf' validation #106

boethomas-corp opened this issue Apr 25, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@boethomas-corp
Copy link

Version

4.4.1

Context

After upgrading from version 4.2.7 to 4.4.1, I have noticed that validating a number field which has 'multipleOf 0.001' defined in Open API 3 fails for numbers like 1.001, 1.01, 1.02, but passes for numbers like 0.001, 0.002.

Do you have a reproducer?

No, but the changes made in the code are transparent.

Steps to reproduce

The bug was already reported in this issue:
vert-x3/vertx-web#2105

But it was reverted in this commit:
a51e3e3

Question

Since the OpenAPI3SchemaParser class which includes the MultipleOfValidatorFactory is marked as deprecated, is there an alternative solution planned for future releases?

@boethomas-corp boethomas-corp added the bug Something isn't working label Apr 25, 2023
@pk-work pk-work added the help wanted Extra attention is needed label May 31, 2024
@pmlopes
Copy link
Contributor

pmlopes commented Jun 4, 2024

For the record, the reason why the test was disabled was because the fixture test suite, was not the official openapi test suite. Given that the new implementation uses the official test suite and passed the tests, we ignored these tests as it was not a trivial fix. (Not the best solution, but we needed some help to fix the old implementation to behave correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants