Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alignWithFirstAttr option to xml.format.splitAttributes #1560

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add alignWithFirstAttr option to xml.format.splitAttributes #1560

merged 1 commit into from
Jul 26, 2023

Conversation

JessicaJHee
Copy link
Contributor

@JessicaJHee
Add alignWithFirstAttr option to xml.format.splitAttributes
a0f51a1 
Signed-off-by: Jessica He <jhe@redhat.com>
@JessicaJHee JessicaJHee mentioned this pull request Jul 26, 2023
Merged
datho7561
datho7561 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, Jessica!

@datho7561
Copy link
Contributor

datho7561 commented Jul 26, 2023 •
edited
Loading

Actually, let me confirm, but preserveAttributeLineBreaks might not be working properly... (maybe I'm doing something wrong, though) nevermind it's working!

@datho7561 datho7561 added this to the 0.27.0 milestone Jul 26, 2023
@datho7561 datho7561 added enhancement New feature or request formatting This issue or enhancement is related to formatting support labels Jul 26, 2023
@datho7561 datho7561 merged commit 2b0fe29 into eclipse:main Jul 26, 2023
4 checks passed
vrubezhny added a commit to vrubezhny/wildwebdeveloper that referenced this pull request Aug 10, 2023
@vrubezhny
Add alignWithFirstAttr option to xml.format.splitAttributes
0f8174d 
See: eclipse/lemminx#1560
@vrubezhny vrubezhny mentioned this pull request Aug 10, 2023
Merged
vrubezhny added a commit to eclipse-wildwebdeveloper/wildwebdeveloper that referenced this pull request Aug 10, 2023
@vrubezhny
Add alignWithFirstAttr option to xml.format.splitAttributes
dfd64bc 
See: eclipse/lemminx#1560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

@angelozerr angelozerr Awaiting requested review from angelozerr

Assignees
No one assigned
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Align XML attributes when formatting
2 participants
@JessicaJHee @datho7561