XML: Harmonize keyboard shortcuts in auto-rename of tags in general XML editor and pom editor

[dstango]

As suggested by @angelozerr in eclipse-wildwebdeveloper/wildwebdeveloper#1140 (comment) here's a function I found missing as a separate issue:

When the cursor is in an XML tag normally auto rename tag is active. When pressing ESC this auto renaming gets deactivated. Yet there doesn't seem to be an option to re-activate it again. In other Eclipse-Editors like the Java-Editor this can normally accomplished by Ctrl-2 + R or Alt-Shift-R (differing in scope). I'd propose to add such a function for XML, too.

[angelozerr]

In other Eclipse-Editors like the Java-Editor this can normally accomplished by Ctrl-2 + R or Alt-Shift-R (differing in scope).

I think the problem is when you open Maven pom editor. I think if you open pom.xml with generic editor, it should work, no?

If it is working I think #571 should fix this issue.

[dstango]

Yes, my original request started from using the pom editor.
In the generic editor the behavior is somewhat different: ESC doesn't deactivate auto-rename (or only shortly, it kicks in quickly again), yet Alt-Shift-R invokes a rename dialog box that does the job. Ctrl-2 + R does seem to have no effect.
(I only had a chance to check it with an older version 2022-03 right now, as I currently can't connect to my usual work environment.)

[mickaelistria]

In the generic editor the behavior is somewhat different: ESC doesn't deactivate auto-rename (or only shortly, it kicks in quickly again)

Can you please open a separate issue about that? Or repurpose this issue by changing the title so it focuses on that particular behavior?

[dstango]

In the generic editor the behavior is somewhat different: ESC doesn't deactivate auto-rename (or only shortly, it kicks in quickly again)

Can you please open a separate issue about that? Or repurpose this issue by changing the title so it focuses on that particular behavior?

@mickaelistria Don't know exactly what you mean by "that"? I guess the behavior of the generic editor might be fine/as intended?!?
And as @angelozerr wrote the issue in the pom editor might be solved by #571.

Or do you think, pressing "esc" should result in deactivating the auto-rename under cursor?

[mickaelistria]

"that" is the sentence I quoted in my reply before referencing it. "ESC doesn't deactivate auto-rename (or only shortly, it kicks in quickly again)" doesn't seem fine.

Or do you think, pressing "esc" should result in deactivating the auto-rename under cursor?

Yes, I think so.

[dstango]

"that" is the sentence I quoted in my reply before referencing it. "ESC doesn't deactivate auto-rename (or only shortly, it kicks in quickly again)" doesn't seem fine.

Or do you think, pressing "esc" should result in deactivating the auto-rename under cursor?

Yes, I think so.

ah, okay, got it. I changed the issue's title to a more general one, covering this family of issues ;-)

[mickaelistria]

So the issue is really just that Esc doesn't de-activate linkedEdit fully (or that linked edit gets reactivated despite Esc was recently pressed)? I would rather see the title focus on 1 specific behavioral issue; as more general is usually not better.

[dstango]

So the issue is really just that Esc doesn't de-activate linkedEdit fully (or that linked edit gets reactivated despite Esc was recently pressed)? I would rather see the title focus on 1 specific behavioral issue; as more general is usually not better.

I get your point, yet it were two issues, and the first one was supposedly already fixed by @angelozerr ... To make the issue's discussion still related to the title, I didn't want to change the title to something else.

I could open a new issue then, yet I'm having trouble to access my workstation right now to double check (don't like to create new issues without some basic checking if the issue really is an/that issue) and will be on vacation anyhow ...

[mickaelistria]

Ok, so yes, please create a new issue when you have the opportunity.