Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Group introduced caused more confusion rather than helping #232

Closed
Emily-Jiang opened this issue Jan 24, 2020 · 3 comments · Fixed by #236
Closed

Health Group introduced caused more confusion rather than helping #232

Emily-Jiang opened this issue Jan 24, 2020 · 3 comments · Fixed by #236
Milestone

Comments

@Emily-Jiang
Copy link
Member

I reviewed the newly released MP Health 2.2. I am confused about the use case of introducing HealthGroup. What use case is this about? I think it introduces more confusion rather than helping much.
For k8s, we have /heath/live and /health/ready, which are good enough.
For this health group, k8s operation team has no clue which endpoint the groups will belong to. With these extra annotations/endpoints, it is confusing for no obvious reasons.

@Emily-Jiang Emily-Jiang added this to the 2.2 milestone Jan 24, 2020
@xstefank
Copy link
Member

xstefank commented Jan 24, 2020

@Emily-Jiang The original issue is #81 which was a request from the community. I responded in the google group.

@antoinesd
Copy link
Contributor

Sorry @Emily-Jiang, I really don't get what is confusing in this very straightforward feature. I also answered in the group

@antoinesd
Copy link
Contributor

Ok, after group discussion, we decided to revert @HealthGroup for 2.2 and continue discussion in #81 for 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants