microprofile-health-81 Ability to execute only some health checks #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding annotations Amend specification Add TCK tests Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
antoinesd
force-pushed
the
microprofile-health-81
branch
from
0272619 to
7e541b5
Compare
xstefank
requested changes
Jan 10, 2020
tck/src/main/java/org/eclipse/microprofile/health/tck/MultipleCustomFailedTest.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/health/tck/MultipleCustomFailedTest.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/health/tck/MultipleCustomFailedTest.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/health/tck/SingleCustomSuccessfulTest.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/health/tck/deployment/FailedCustom.java
Show resolved
Hide resolved
Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
|
@antoinesd did you verify that the new TCK can pass? |
|
Not yet. Do you want implement the feature in smallRye to test or do you prefer that I do it ? |
|
@antoinesd I implemented this in SmallRye. Everything passes. Thanks. |
xstefank
approved these changes
Jan 12, 2020
There was a problem hiding this comment.
Just a few suggestions. I would also recommend to add something similar like this to the HealthGroup qualifier:
public class HealthGroupLiteral extends AnnotationLiteral<HealthGroup> implements HealthGroup {
private String groupName;
public HealthGroupLiteral(String groupName) {
this.groupName = groupName;
}
public static HealthGroupLiteral of(String groupName) {
return new HealthGroupLiteral(groupName);
}
@Override
public String value() {
return groupName;
}
}as was originally proposed and it will be repeated in individual implementations. But this can be added in separate PR if you prefer.
typo Co-Authored-By: Martin Stefanko <xstefank122@gmail.com>
typo Co-Authored-By: Martin Stefanko <xstefank122@gmail.com>
|
@antoinesd thanks for the updates. Should we merge this PR and add Literal in a separate one? Or are you still going to include it here? |
|
I'll create anther PR for literals since it could be useful to have ones for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #81
Adding annotations
Amend specification
Add TCK tests
Signed-off-by: Antoine Sabot-Durand antoine@sabot-durand.net