Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent, add module-info, streamline OSGi annotation dependency #577

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

MikeEdgar
Copy link
Contributor

Update parent, add module-info, streamline OSGi annotation dependency. Removes dependency on the biz.aQute.bnd artifact as the osgi.annotation should be the only one necessary.

Fixes #573

I will also submit a follow-up PR with the changes for #574 once this is merged.

Signed-off-by: Michael Edgar <michael@xlate.io>
Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me

@Azquelt
Copy link
Member

Azquelt commented Jan 18, 2024

You've left this in draft, was there anything you still wanted to change before it's merged?

@MikeEdgar MikeEdgar marked this pull request as ready for review January 18, 2024 16:31
@MikeEdgar
Copy link
Contributor Author

No, nothing additional to change.

@MikeEdgar MikeEdgar merged commit 868048f into microprofile:main Jan 18, 2024
4 checks passed
@MikeEdgar MikeEdgar deleted the module-info branch January 18, 2024 16:33
@Emily-Jiang
Copy link
Member

You should use the mp-parent 2.x not 3.x as 3.x will pull in Jakarta EE 10 api but this spec does not use any Jakarta EE 10 new APIs. Therefore, it should be built with Jakarta EE 9.1.

@MikeEdgar
Copy link
Contributor Author

@Emily-Jiang are we able to set the compiler release to 11 since 2.x is still using 1.8? Otherwise we will need to remove the module-info and possibly revert the OSGi dependency changes.

@Emily-Jiang
Copy link
Member

@Emily-Jiang are we able to set the compiler release to 11 since 2.x is still using 1.8? Otherwise we will need to remove the module-info and possibly revert the OSGi dependency changes.

yes, you can override it to be 11 in your own pom.xml

@Azquelt
Copy link
Member

Azquelt commented Jul 1, 2024

The module-info appears to cause some trouble building the aggregated javadoc: eclipse/microprofile#443

I'm looking into it, but if anyone has any ideas I'd appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MP Parent version deviates from MP Parent TCK BOM version
3 participants