-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate failing example tests #3193
Comments
@LorenzoBettini wonder if we can archive the screenshots somehow if swtbot takes any |
at least locally i see 2 launch configs for the xtend anno example. no idea why |
|
=> looks like the workaround transitive dependeny does not work for some reason? |
@szarnekow @LorenzoBettini do you have an idea? maybe its not in the tp or the stupid swtbot tests |
hmmm explicitely adding leads to com.google.inject.ProvisionException: Unable to provision, see the following errors:
Learn more: 1 error ======================
|
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich Yes, see for example https://github.com/LorenzoBettini/edelta/blob/master/.github/workflows/maven.yml#L67 To be honest, I thought we already archived screenshots in Xtext itself, but maybe we never needed to. |
@cdietrich when it happened in the past in my projects, that was due to some changed transitive/re-exported dependencies. Explicitly adding the dep used to work for me. |
dm example still does not work :( |
|
@szarnekow any idea? |
wonder why the patch for |
java.lang.NullPointerException: Cannot invoke "org.eclipse.core.runtime.Plugin.getBundle()" because the return value of "org.eclipse.jdt.core.JavaCore.getPlugin()" is null of course this CRAPPPPPPPPP => check if setter is there. if yes invoke it :( |
Or in this case, catch the NPE? |
Moreover, we should have a test for the on the fly compiler. |
I think we do have tests but those are often executed as plugin tests, no? |
yes |
But that should be the case for domainmodel as well, during a Maven build. |
yes this is what the swt bot tests in xtext-reference-projects/integrationtests do. |
with 2nd fix it seems to work |
https://github.com/xtext/xtext-reference-projects/actions/runs/10860556518
No idea why
(assertion for unit tests seems to fail)
xtend examples fail too
https://github.com/xtext/xtext-reference-projects/actions/runs/10859774718/job/30139568409
(also test fails here)
The text was updated successfully, but these errors were encountered: