Skip to content

Commit c88c79a

Browse files
committed
Minor tidy up
1 parent d910428 commit c88c79a

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

src/gribjump/Engine.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ TaskOutcome<size_t> Engine::scan(const MarsRequests& requests, bool byfiles) {
172172

173173
std::vector<eckit::URI> uris = FDBLister::instance().URIs(requests);
174174

175-
// XXX do we explicitly need this?
175+
/// @todo do we explicitly need this?
176176
if (uris.empty()) {
177177
MetricsManager::instance().set("count_scanned_fields", 0);
178178
return {0, TaskReport()};

src/gribjump/Engine.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class Engine {
3535
Engine();
3636
~Engine();
3737

38-
// ResultsMap extract(ExtractionRequests& requests);
3938
TaskOutcome<ResultsMap> extract(ExtractionRequests& requests);
4039

4140
// byfiles: scan entire file, not just fields matching request

src/gribjump/LocalGribJump.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,6 @@ ResultsMap LocalGribJump::extract(const std::vector<std::string>& requests, cons
119119
}
120120

121121
std::map<std::string, std::unordered_set<std::string>> LocalGribJump::axes(const std::string& request, int level) {
122-
123-
// Note: This is likely to be removed from GribJump, and moved to FDB.
124-
// Here for now to support polytope.
125-
126122
return Engine().axes(request, level);
127123
}
128124

src/gribjump/remote/Request.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ namespace gribjump {
2828
//----------------------------------------------------------------------------------------------------------------------
2929

3030
class Request {
31-
public: // methods
31+
public:
3232

3333
Request(eckit::Stream& stream);
3434

@@ -45,8 +45,8 @@ class Request {
4545
protected: // members
4646

4747
eckit::Stream& client_;
48-
Engine engine_; //< Engine and schedule tasks based on request // XXX Can we now remove this?
49-
TaskReport report_; //
48+
Engine engine_;
49+
TaskReport report_;
5050
uint64_t id_;
5151
};
5252

0 commit comments

Comments
 (0)